Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1678043002: [arm] Add several missing vcvt disassembly tests. (Closed)

Created:
4 years, 10 months ago by jbramley
Modified:
4 years, 10 months ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Add several missing vcvt disassembly tests. BUG= Committed: https://crrev.com/4d1f84921b37215327009d83a8fd081fc1519d17 Cr-Commit-Position: refs/heads/master@{#33811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -18 lines) Patch
M test/cctest/test-disasm-arm.cc View 2 chunks +42 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
This includes the test I mentioned here: https://codereview.chromium.org/1627263002/#msg20
4 years, 10 months ago (2016-02-08 10:25:19 UTC) #2
titzer
lgtm
4 years, 10 months ago (2016-02-08 10:50:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678043002/1
4 years, 10 months ago (2016-02-08 11:26:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 11:45:24 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 11:45:45 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4d1f84921b37215327009d83a8fd081fc1519d17
Cr-Commit-Position: refs/heads/master@{#33811}

Powered by Google App Engine
This is Rietveld 408576698