third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h - Issue 1678003002: Remove sampling trace events from the binding layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 1678003002: Remove sampling trace events from the binding layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp ('k') | third_party/WebKit/Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

index 7672a71aba34a0e8489ad8cd0e67a2818757525f..5d709e7367293085c003c595ad0c0f1b76dbdd35 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

@@ -111,9 +111,6 @@ public:

v8::Local<v8::Context> ensureScriptRegexpContext();

void clearScriptRegexpContext();

- const char* previousSamplingState() const { return m_previousSamplingState; }

- void setPreviousSamplingState(const char* name) { m_previousSamplingState = name; }

// EndOfScopeTasks are run by V8RecursionScope when control is returning

// to C++ from script, after executing a script task (e.g. callback,

// event) or microtasks (e.g. promise). This is explicitly needed for

@@ -143,8 +140,6 @@ private:

ScopedPersistent<v8::Value> m_liveRoot;

RefPtr<ScriptState> m_scriptRegexpScriptState;

- const char* m_previousSamplingState;

bool m_constructorMode;

friend class ConstructorMode;