runtime/vm/snapshot.cc - Issue 16780009: When canonicalize instances check if all fields are canonical. If a field is a non-canonical number…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/snapshot.cc

Issue 16780009: When canonicalize instances check if all fields are canonical. If a field is a non-canonical number… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/snapshot.cc

===================================================================

--- runtime/vm/snapshot.cc (revision 23933)

+++ runtime/vm/snapshot.cc (working copy)

@@ -795,7 +795,8 @@

if (kind_ == Snapshot::kFull) {

result->SetCreatedFromSnapshot();

} else if (result->IsCanonical()) {

- *result = result->Canonicalize();

+ *result = result->CheckAndCanonicalize(NULL);

+ ASSERT(!result->IsNull());

}

return result->raw();

}

« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »