Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 1677943002: report.format_html now ignores APIs not passed to it. (Closed)

Created:
4 years, 10 months ago by Matthew Alger
Modified:
4 years, 10 months ago
Reviewers:
Matt Giuca
CC:
raymes
Base URL:
https://github.com/chromium/caterpillar.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

report.format_html now ignores APIs not passed to it. Previously, report.format_html would error if it tried to highlight something that looked like an API, but didn't show up in the APIs dict passed to it as an argument. For example, "chrome.google.com" would trigger this bug. This CL changes the behaviour such that if something API-like isn't contained in the APIs dict passed as an argument, then report.format_html will assume that it is not an API, and will ignore it. Resolves https://github.com/chromium/caterpillar/issues/43 . R=mgiuca@chromium.org Committed: 9c3aa80cce5dd44dc8314b0b7205e6118e4942ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/report/report.py View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Matthew Alger
4 years, 10 months ago (2016-02-07 23:17:41 UTC) #2
Matt Giuca
lgtm
4 years, 10 months ago (2016-02-08 02:14:43 UTC) #3
Matthew Alger
4 years, 10 months ago (2016-02-08 02:27:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c3aa80cce5dd44dc8314b0b7205e6118e4942ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698