Disk cache: Disable index table unit tests for iOS.

Disk cache: Disable index table unit tests for iOS.

BUG=344533
R=rdsmith@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251860

[Randy Smith (Not in Mondays), 2014-02-18 17:09:14]

Request: Could you also put a reference to bug 334640 in the CL?

Suggestion: I think of the usual way to disable broken tests on a platform as
being through 

#if defined() 
#define MAYBE_...
#endif

pattern.  That would obviously be a lot more code (though you could probably do
something clever with macro string concatenation to just have the ifdef in one
place) but I think would be more natural for people reading the code.  

Beyond that, LGTM.

[rvargas (doing something else), 2014-02-18 17:35:41]

On 2014/02/18 17:09:14, rdsmith wrote:
> Request: Could you also put a reference to bug 334640 in the CL?

What I'm doing is replacing bot-specific bug reports (that I expect to be closed
right away) with a single bug that explain the issue that is still open. I can
remove the iOS bug from the description, now that droger acknowledged the issue.
Does that sound better?

> 
> Suggestion: I think of the usual way to disable broken tests on a platform as
> being through 
> 
> #if defined() 
> #define MAYBE_...
> #endif
> 
> pattern.  That would obviously be a lot more code (though you could probably
do
> something clever with macro string concatenation to just have the ifdef in one
> place) but I think would be more natural for people reading the code. 

Right, I'd prefer this pattern (excluding the whole file) given that for the
time being no test will run. It is a common pattern when still working on a
port,  as can still be seen regarding excluding wide blocks of tests from iOS.
The intent is to say that the file/feature is not ready on a given platform, not
just that a given individual test is not passing. There is still an undecided
issue about what platforms V3 tests should cover (still talking with other
people about it), but in any case those changes are gyp based, not
inside_the_source based.

Thanks!

> 
> Beyond that, LGTM.

[Randy Smith (Not in Mondays), 2014-02-18 18:36:27]

On 2014/02/18 17:35:41, rvargas wrote:
> On 2014/02/18 17:09:14, rdsmith wrote:
> > Request: Could you also put a reference to bug 334640 in the CL?
> 
> What I'm doing is replacing bot-specific bug reports (that I expect to be
closed
> right away) with a single bug that explain the issue that is still open. I can
> remove the iOS bug from the description, now that droger acknowledged the
issue.
> Does that sound better?

Yep, that sounds good.

> 
> > 
> > Suggestion: I think of the usual way to disable broken tests on a platform
as
> > being through 
> > 
> > #if defined() 
> > #define MAYBE_...
> > #endif
> > 
> > pattern.  That would obviously be a lot more code (though you could probably
> do
> > something clever with macro string concatenation to just have the ifdef in
one
> > place) but I think would be more natural for people reading the code. 
> 
> Right, I'd prefer this pattern (excluding the whole file) given that for the
> time being no test will run. It is a common pattern when still working on a
> port,  as can still be seen regarding excluding wide blocks of tests from iOS.
> The intent is to say that the file/feature is not ready on a given platform,
not
> just that a given individual test is not passing. There is still an undecided
> issue about what platforms V3 tests should cover (still talking with other
> people about it), but in any case those changes are gyp based, not
> inside_the_source based.
> 
> Thanks!
> 
> > 
> > Beyond that, LGTM.

[rvargas (doing something else), 2014-02-18 19:42:36]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-02-18 19:43:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rvargas@chromium.org/167793003/60001

[commit-bot: I haz the power, 2014-02-18 22:27:25]

Change committed as 251860