Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 167793002: Removes --disable-ime-mode-indicator flag. (Closed)

Created:
6 years, 10 months ago by Jun Mukai
Modified:
6 years, 10 months ago
CC:
chromium-reviews, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, yukishiino+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, yusukes+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove unnecessary weak_factory #

Patch Set 3 : moar remove #

Patch Set 4 : rebase #

Total comments: 4

Patch Set 5 : cleanup includes #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -123 lines) Patch
M ash/system/ime/ime_observer.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M ash/system/ime/tray_ime.h View 1 2 3 4 3 chunks +1 line, -12 lines 0 comments Download
M ash/system/ime/tray_ime.cc View 1 2 3 4 6 chunks +2 lines, -55 lines 0 comments Download
M ash/system/system_notifier.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/system_notifier.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_notifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/input_method/accessibility.cc View 1 2 3 4 5 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_controller.cc View 1 2 3 4 5 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 3 4 5 3 chunks +2 lines, -11 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Jun Mukai
6 years, 10 months ago (2014-02-14 22:29:08 UTC) #1
Jun Mukai
R+=komatsu
6 years, 10 months ago (2014-02-14 23:37:41 UTC) #2
Hiro Komatsu
https://codereview.chromium.org/167793002/diff/100001/chrome/browser/chromeos/input_method/accessibility.cc File chrome/browser/chromeos/input_method/accessibility.cc (left): https://codereview.chromium.org/167793002/diff/100001/chrome/browser/chromeos/input_method/accessibility.cc#oldcode40 chrome/browser/chromeos/input_method/accessibility.cc:40: // delete command_line.h and chromeos_switches.h from the header please ...
6 years, 10 months ago (2014-02-16 00:00:32 UTC) #3
Jun Mukai
https://codereview.chromium.org/167793002/diff/100001/chrome/browser/chromeos/input_method/accessibility.cc File chrome/browser/chromeos/input_method/accessibility.cc (left): https://codereview.chromium.org/167793002/diff/100001/chrome/browser/chromeos/input_method/accessibility.cc#oldcode40 chrome/browser/chromeos/input_method/accessibility.cc:40: // delete command_line.h and chromeos_switches.h from the header On ...
6 years, 10 months ago (2014-02-18 20:37:11 UTC) #4
Hiro Komatsu
lgtm
6 years, 10 months ago (2014-02-19 04:18:20 UTC) #5
Jun Mukai
Adding owners. Please take a look: stevenjb for ash/system oshima for chromeos/ and chrome/browser/ui/ash
6 years, 10 months ago (2014-02-19 18:26:59 UTC) #6
stevenjb
owner lgtm
6 years, 10 months ago (2014-02-19 18:31:24 UTC) #7
oshima
lgtm
6 years, 10 months ago (2014-02-19 18:41:54 UTC) #8
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-19 18:43:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/167793002/320001
6 years, 10 months ago (2014-02-19 18:48:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/167793002/320001
6 years, 10 months ago (2014-02-20 00:02:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/167793002/320001
6 years, 10 months ago (2014-02-20 01:16:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/167793002/320001
6 years, 10 months ago (2014-02-20 05:03:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/167793002/320001
6 years, 10 months ago (2014-02-20 08:59:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/167793002/320001
6 years, 10 months ago (2014-02-20 12:25:06 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 13:55:06 UTC) #16
Message was sent while issue was closed. 
Change committed as 252229

Powered by Google App Engine
This is Rietveld 408576698