Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 16779004: Allow the deoptimizer translation to track de-materialized objects. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Allow the deoptimizer translation to track de-materialized objects. This allows the deoptimizer to materialize objects (e.g. the arguments object) while deopting without having a consective stack area holding the object values. The LEnvironment explicitly tracks locations for these values and preserves them in the translation. R=svenpanne@chromium.org TEST=mjsunit/compiler/inline-arguments Committed: http://code.google.com/p/v8/source/detail?r=15087

Patch Set 1 #

Patch Set 2 : Ported to ARM and x64 architectures. #

Patch Set 3 : Improved comments slightly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+543 lines, -312 lines) Patch
M src/arm/lithium-arm.cc View 1 3 chunks +20 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 7 chunks +31 lines, -58 lines 0 comments Download
M src/data-flow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 8 chunks +17 lines, -11 lines 0 comments Download
M src/deoptimizer.cc View 17 chunks +253 lines, -52 lines 0 comments Download
M src/hydrogen.h View 3 chunks +7 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 7 chunks +23 lines, -28 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +26 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 2 chunks +2 lines, -8 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 7 chunks +31 lines, -58 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +20 lines, -2 lines 0 comments Download
M src/lithium.h View 1 2 7 chunks +11 lines, -7 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 7 chunks +31 lines, -58 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 3 chunks +20 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/inline-arguments.js View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
The architecture ports are not yet done, but I wanted to get a first round ...
7 years, 6 months ago (2013-06-11 16:56:08 UTC) #1
Michael Starzinger
Finished architecture ports.
7 years, 6 months ago (2013-06-12 11:50:09 UTC) #2
Sven Panne
lgtm
7 years, 6 months ago (2013-06-12 12:59:03 UTC) #3
Michael Starzinger
7 years, 6 months ago (2013-06-12 14:23:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r15087 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698