Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1677753002: Mojo C++ bindings: InterfacePtr::PassInterface -> PassInterfaceHandle (Closed)

Created:
4 years, 10 months ago by vardhan
Modified:
4 years, 10 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojo C++ bindings: InterfacePtr::PassInterface -> PassInterfaceHandle R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a8bfcc868ec051c2be76b00e2715ef96bd55ade8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M examples/indirect_service/indirect_service_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/spinning_cube/gles2_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/noodles/noodles_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/gl_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/application_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_serialization.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/log/cpp/lib/log_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/dart/content_handler_app_service_connector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/gfx/compositor/backend/gpu_output.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vardhan
ptal
4 years, 10 months ago (2016-02-05 22:44:59 UTC) #1
viettrungluu
lgtm
4 years, 10 months ago (2016-02-05 22:47:36 UTC) #2
vardhan
4 years, 10 months ago (2016-02-05 22:55:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8bfcc868ec051c2be76b00e2715ef96bd55ade8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698