Make SyzyAsan depend on 'syzyasan' GYP flag instead of 'asan==1 and OS=="win"'

Make SyzyAsan depend on 'syzyasan' GYP flag instead of 'asan==1 and OS=="win"'

We're bringing the regular Clang-based ASan to Windows and will put it behind
asan==1 like on all other platforms.

BUG=343960
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251518

[hans, 2014-02-14 22:13:55]

Here's a first step toward disambiguating the 'asan' GYP flag. Please take a
look.

[Sébastien Marchand, 2014-02-14 22:21:32]

lgtm, although I'm not owner for any of those files.

Next step will be to update the buildbots to use 'syzyasan' instead of 'asan'.
They're all under the 'Win ASan' group on
http://build.chromium.org/p/chromium.fyi/console , feel free to also rename them
(i.e to "Win SyzyASan Builder" instead of "Win ASAN Builder"...).

There's also an official builder for the canary builds to update.

[hans, 2014-02-14 22:23:03]

On 2014/02/14 22:21:32, Sébastien Marchand wrote:
> lgtm, although I'm not owner for any of those files.
> 
> Next step will be to update the buildbots to use 'syzyasan' instead of 'asan'.
> They're all under the 'Win ASan' group on
> http://build.chromium.org/p/chromium.fyi/console , feel free to also rename
them
> (i.e to "Win SyzyASan Builder" instead of "Win ASAN Builder"...).

Thanks! I'm working on the patch :)

> There's also an official builder for the canary builds to update.

Do you know where the buildbot config for that lives?

[Nico, 2014-02-14 22:24:31]

lgtm if the trybots like it

[hans, 2014-02-14 22:27:31]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-02-14 22:35:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/167773002/1

[commit-bot: I haz the power, 2014-02-14 23:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 23:06:41]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[hans, 2014-02-14 23:09:19]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-02-14 23:22:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/167773002/1

[commit-bot: I haz the power, 2014-02-15 03:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-15 03:23:40]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Nico, 2014-02-15 03:40:42]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-02-15 03:41:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/167773002/1

[commit-bot: I haz the power, 2014-02-15 04:49:20]

Change committed as 251518