Issue 1677703002: Fix last remaining failing dart inspector layout test. Simplify scope-variables.html to not reach i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1677703002: Fix last remaining failing dart inspector layout test. Simplify scope-variables.html to not reach i… (Closed)

Created:
4 years, 10 months ago by Jacob

Modified:
4 years, 10 months ago

Reviewers:
Alan Knight, terry

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/blink/branches/dart/2454_1

Target Ref:
refs/remotes/git-svn

Project:
blink

Visibility:
Public.

Fix last remaining failing dart inspector layout test. Simplify scope-variables.html to not reach into JS inspector test framework internals as much. BUG= Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=202771

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -57 lines)			Patch
M	LayoutTests/dart/inspector/scope-variables.html	View	3 chunks	+15 lines, -45 lines	0 comments	Download
M	LayoutTests/dart/inspector/scope-variables-expected.txt	View	3 chunks	+8 lines, -11 lines	0 comments	Download
M	Source/bindings/core/dart/DartInjectedScript.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Jacob

Committed patchset #1 (id:1) manually as 202771 (tree was closed).

4 years, 10 months ago (2016-02-05 21:09:28 UTC) #2

Message was sent while issue was closed.

lgtm