Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 1677503002: [turbofan] Fixes the code generation for branches on x64 when the condition is Word64Equal. (Closed)

Created:
4 years, 10 months ago by epertoso
Modified:
4 years, 10 months ago
Reviewers:
*Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fixes the code generation for branches on x64 when the condition is Word64Equal. Before: REX.W cmpq r9,r8 setzl r8l movzxbl r8,r8 REX.W cmpq r8,0x0 jz 185 After: REX.W cmpq r9,r8 jnz 149 Committed: https://crrev.com/75cc8352d06aada2e9131fdae793299ef73fb639 Cr-Commit-Position: refs/heads/master@{#33784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -35 lines) Patch
M src/compiler/x64/instruction-selector-x64.cc View 3 chunks +21 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
epertoso
4 years, 10 months ago (2016-02-05 14:29:00 UTC) #3
Benedikt Meurer
Nice catch! LGTM
4 years, 10 months ago (2016-02-05 14:29:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677503002/1
4 years, 10 months ago (2016-02-05 14:30:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 15:00:55 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/75cc8352d06aada2e9131fdae793299ef73fb639 Cr-Commit-Position: refs/heads/master@{#33784}
4 years, 10 months ago (2016-02-05 15:01:19 UTC) #11
epertoso
4 years, 10 months ago (2016-02-11 09:22:42 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1693433002/ by epertoso@chromium.org.

The reason for reverting is: Code like the example given in the CL description
was produced, for example, by code-stub-assembler.cc.

Reverting this, and try to fix the root cause instead..

Powered by Google App Engine
This is Rietveld 408576698