Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1677453002: [swarming] Roll luci-go/isolate. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Roll luci-go/isolate. Ports https://codereview.chromium.org/1671753002 It brings auth support (so developers can use 'isolate' if they really want to) and adds *.pyc to default isolate blacklist. TBR=maruel@chromium.org, vadimsh@chromium.org, stip@chromium.org BUG=584073 LOG=n Committed: https://crrev.com/dfc09f6851afa36c50c1a71ea61ea3c31fe6dd7d Cr-Commit-Position: refs/heads/master@{#33763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/luci-go/linux64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/mac64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/win64/isolate.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Michael Achenbach
TBR
4 years, 10 months ago (2016-02-05 08:38:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677453002/1
4 years, 10 months ago (2016-02-05 08:38:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10587)
4 years, 10 months ago (2016-02-05 08:46:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677453002/1
4 years, 10 months ago (2016-02-05 08:56:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 09:03:14 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dfc09f6851afa36c50c1a71ea61ea3c31fe6dd7d Cr-Commit-Position: refs/heads/master@{#33763}
4 years, 10 months ago (2016-02-05 09:03:41 UTC) #14
Vadim Sh.
lgtm I wasn't aware of v8 use of isolate client. Doing double rolls sucks.
4 years, 10 months ago (2016-02-05 09:11:30 UTC) #15
M-A Ruel
On 2016/02/05 09:11:30, Vadim Sh. wrote: > lgtm > > I wasn't aware of v8 ...
4 years, 10 months ago (2016-02-05 18:44:20 UTC) #16
Vadim Sh.
On 2016/02/05 18:44:20, M-A Ruel wrote: > On 2016/02/05 09:11:30, Vadim Sh. wrote: > > ...
4 years, 10 months ago (2016-02-05 20:23:20 UTC) #17
Michael Achenbach
4 years, 10 months ago (2016-02-05 20:48:40 UTC) #18
Message was sent while issue was closed.
On 2016/02/05 20:23:20, Vadim Sh. wrote:
> On 2016/02/05 18:44:20, M-A Ruel wrote:
> > On 2016/02/05 09:11:30, Vadim Sh. wrote:
> > > lgtm
> > > 
> > > I wasn't aware of v8 use of isolate client. Doing double rolls sucks.
> > 
> > Skia too. That's why migrating to buildtools is a priority.
> 
> Buildtools won't fix the issue of many rolls. We'd need to roll buildtools
> manually too in each individual repo.

Buildtools is deps'ed in. We can use automatic deps rollers easily. E.g. v8
already automatically updates all deps to match chromium's deps.  Sha1 files are
different (we could write auto-rollers for those too of course, but I'd prefer
fewer services to maintain).

Powered by Google App Engine
This is Rietveld 408576698