Adding support for asm.js foreign globals.

Adding support for asm.js foreign globals.

Since wasm has no direct notion of foreign globals,
pass the ffi object on to the AsmWasmBuilder
so that foreign globals can be extracted at module
instantiation time.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=mjsunit/asm-wasm
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/821c603e0c5f5c25ac198afaf9463f454d9a96db
Cr-Commit-Position: refs/heads/master@{#33956}

[aseemgarg, 2016-02-09 02:38:56]

https://codereview.chromium.org/1677373002/diff/1/src/wasm/asm-wasm-builder.cc
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1677373002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:641: if (!key_literal->value().is_null() &&
!foreign_.is_null()) {
Not sure of these constructs. @Ben, can you review.

https://codereview.chromium.org/1677373002/diff/1/test/mjsunit/wasm/asm-wasm.js
File test/mjsunit/wasm/asm-wasm.js (right):

https://codereview.chromium.org/1677373002/diff/1/test/mjsunit/wasm/asm-wasm....
test/mjsunit/wasm/asm-wasm.js:1085: function TestForeignVariables() {
Might want to also write test that uses same foreign variable both as int and
double.

https://codereview.chromium.org/1677373002/diff/1/test/mjsunit/wasm/asm-wasm....
test/mjsunit/wasm/asm-wasm.js:1110: // Check that undefined values are converted
to zero.
As discussed, doubles should flow as NaNs. Please fix.

[bradnelson, 2016-02-09 04:55:23]

titzer, ptal

https://codereview.chromium.org/1677373002/diff/1/src/wasm/asm-wasm-builder.cc
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1677373002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:641: if (!key_literal->value().is_null() &&
!foreign_.is_null()) {
On 2016/02/09 02:38:55, aseemgarg wrote:
> Not sure of these constructs. @Ben, can you review.

Yes please!

https://codereview.chromium.org/1677373002/diff/1/test/mjsunit/wasm/asm-wasm.js
File test/mjsunit/wasm/asm-wasm.js (right):

https://codereview.chromium.org/1677373002/diff/1/test/mjsunit/wasm/asm-wasm....
test/mjsunit/wasm/asm-wasm.js:1085: function TestForeignVariables() {
On 2016/02/09 02:38:56, aseemgarg wrote:
> Might want to also write test that uses same foreign variable both as int and
> double.

Done.

https://codereview.chromium.org/1677373002/diff/1/test/mjsunit/wasm/asm-wasm....
test/mjsunit/wasm/asm-wasm.js:1110: // Check that undefined values are converted
to zero.
On 2016/02/09 02:38:56, aseemgarg wrote:
> As discussed, doubles should flow as NaNs. Please fix.

Done.

[bradnelson, 2016-02-09 19:43:29]

So I'm now using ToNumber and ToInt32 as appropriate.
I emailed you separately as in general proxies seem to blow up ffi.
You'd mentioned Object.observe, but it occurred to me later that it only cares
about changes, we're only reading once at initialization, which doesn't trigger
observe handlers (unless I'm missing something?).

[bradnelson, 2016-02-10 17:37:53]

Added tests of Date, more strings, toValue

[bradn, 2016-02-12 01:40:41]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-02-12 01:40:41]

Added more asserts as you suggested Aseem.
Ben, unless you have concerns I'd like to land.
Can haz lg ?

[titzer, 2016-02-12 13:03:28]

lgtm

[bradn, 2016-02-12 17:17:30]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-02-12 17:17:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1677373002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1677373002/120001

[commit-bot: I haz the power, 2016-02-12 17:31:12]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-02-12 17:31:58]

Description was changed from

==========
Adding support for asm.js foreign globals.

Since wasm has no direct notion of foreign globals,
pass the ffi object on to the AsmWasmBuilder
so that foreign globals can be extracted at module
instantiation time.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=mjsunit/asm-wasm
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Adding support for asm.js foreign globals.

Since wasm has no direct notion of foreign globals,
pass the ffi object on to the AsmWasmBuilder
so that foreign globals can be extracted at module
instantiation time.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=mjsunit/asm-wasm
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/821c603e0c5f5c25ac198afaf9463f454d9a96db
Cr-Commit-Position: refs/heads/master@{#33956}
==========

[commit-bot: I haz the power, 2016-02-12 17:31:59]

Patchset 7 (id:??) landed as
https://crrev.com/821c603e0c5f5c25ac198afaf9463f454d9a96db
Cr-Commit-Position: refs/heads/master@{#33956}