mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl - Issue 1677343002: mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl

Issue 1677343002: mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/mojom_types.mojom ('k') | mojo/public/tools/bindings/mojom_parser/bin/linux64/mojom_parser.sha1 » ('j') | mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl b/mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl

index 82ea195fb14cccbc07f4f47abcba26a0e9d0bf5e..32eaf3c001b653ce4c6a66b1522131aa9fb874d0 100644

--- a/mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl

@@ -21,7 +21,7 @@

..declData = (new {{typepkg}}DeclarationData()

..shortName = '{{type|mojom_type_name|upper_camel}}'

..fullIdentifier = '{{type|fullidentifier}}')

- ..interfaceName = '{{type|name}}'

+ ..serviceName_ = '{{type|name}}'

azani 2016/02/10 00:06:39 This changes the name in dart bindings. Is that wh

rudominer 2016/02/10 00:43:49 This is changing the name in the generated code th

..methods = <int, {{typepkg}}MojomMethod>{

{%- for method in type.methods %}

_{{type|name}}_{{method|name}}Name: new {{typepkg}}MojomMethod()