Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 167733005: [telemetry] Fix browser finding on Windows. (Closed)

Created:
6 years, 10 months ago by dtu
Modified:
6 years, 10 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Fix browser finding on Windows. Fix indent typo, and get rid of really awkward use of closures. BUG=None. TEST=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252788

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dtu
trololol
6 years, 10 months ago (2014-02-22 00:54:48 UTC) #1
tonyg
lgtm
6 years, 10 months ago (2014-02-22 01:00:34 UTC) #2
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 10 months ago (2014-02-22 01:01:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/167733005/30001
6 years, 10 months ago (2014-02-22 01:03:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/167733005/30001
6 years, 10 months ago (2014-02-22 01:37:38 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 08:39:50 UTC) #6
Message was sent while issue was closed.
Change committed as 252788

Powered by Google App Engine
This is Rietveld 408576698