Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1677303002:
Remove win aura theme references (Closed)
|
Created:
4 years, 10 months ago by Evan Stade Modified:
4 years, 10 months ago CC:
chromium-reviews, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove win aura theme references
BUG=558054
Committed: https://crrev.com/4d3a9b186533c737aaa5bf49bbad33fea5135ec7
Cr-Commit-Position: refs/heads/master@{#374406}
Patch Set 1 #
Total comments: 3
Patch Set 2 : increment theme version no #
Messages
Total messages: 23 (11 generated)
The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677303002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
estade@chromium.org changed reviewers: + pkotwicz@chromium.org
https://codereview.chromium.org/1677303002/diff/1/chrome/browser/themes/brows... File chrome/browser/themes/browser_theme_pack.cc (right): https://codereview.chromium.org/1677303002/diff/1/chrome/browser/themes/brows... chrome/browser/themes/browser_theme_pack.cc:90: // not change between versions of chrome. does this comment mean it's not OK to just delete PRS_*_DESKTOP?
LGTM, but please increment kThemePackVersion https://codereview.chromium.org/1677303002/diff/1/chrome/browser/themes/brows... File chrome/browser/themes/browser_theme_pack.cc (right): https://codereview.chromium.org/1677303002/diff/1/chrome/browser/themes/brows... chrome/browser/themes/browser_theme_pack.cc:90: // not change between versions of chrome. This comment indicates that you must change kThemePackVersion. This will force the theme to be re-extracted from the .crx.
https://codereview.chromium.org/1677303002/diff/1/chrome/browser/themes/brows... File chrome/browser/themes/browser_theme_pack.cc (right): https://codereview.chromium.org/1677303002/diff/1/chrome/browser/themes/brows... chrome/browser/themes/browser_theme_pack.cc:90: // not change between versions of chrome. On 2016/02/09 00:23:54, pkotwicz wrote: > This comment indicates that you must change kThemePackVersion. This will force > the theme to be re-extracted from the .crx. Done.
The CQ bit was checked by estade@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkotwicz@chromium.org Link to the patchset: https://codereview.chromium.org/1677303002/#ps20001 (title: "increment theme version no")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677303002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Remove win aura theme references BUG=558054 ========== to ========== Remove win aura theme references BUG=558054 ==========
estade@chromium.org changed reviewers: + oshima@chromium.org
+oshima for theme_resources.grd
lgtm
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677303002/20001
Message was sent while issue was closed.
Description was changed from ========== Remove win aura theme references BUG=558054 ========== to ========== Remove win aura theme references BUG=558054 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove win aura theme references BUG=558054 ========== to ========== Remove win aura theme references BUG=558054 Committed: https://crrev.com/4d3a9b186533c737aaa5bf49bbad33fea5135ec7 Cr-Commit-Position: refs/heads/master@{#374406} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4d3a9b186533c737aaa5bf49bbad33fea5135ec7 Cr-Commit-Position: refs/heads/master@{#374406} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
