Add tracing for functions processed by code flushing.

Add tracing for functions processed by code flushing.

R=hpayer@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=15064

[Hannes Payer (out of office), 2013-06-11 14:07:17]

https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc#newcode1135
src/mark-compact.cc:1135: PrintF("[code-flushing resurrects: %s]\n", *name);
why don't you say "code-flushing evicts: ..."?

https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc#newcode1171
src/mark-compact.cc:1171: PrintF("[code-flushing resurrects: %s]\n", *name);
why don't you say "code-flushing evicts: ..."?

https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc#newcode1197
src/mark-compact.cc:1197: void
CodeFlusher::EvictOptimizedCodeMap(SharedFunctionInfo* code_map_holder) {
Do you want to add tracing support to this function as well?

[Michael Starzinger, 2013-06-11 14:34:13]

Addressed comments. Landing.

https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc#newcode1135
src/mark-compact.cc:1135: PrintF("[code-flushing resurrects: %s]\n", *name);
On 2013/06/11 14:07:17, Hannes Payer wrote:
> why don't you say "code-flushing evicts: ..."?

As discussed offline: Using 'evicts' here sound a lot like the code-flusher
actually did flush the code, which is not the case. We decided to use 'abandons'
instead.

https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc#newcode1171
src/mark-compact.cc:1171: PrintF("[code-flushing resurrects: %s]\n", *name);
On 2013/06/11 14:07:17, Hannes Payer wrote:
> why don't you say "code-flushing evicts: ..."?

See above.

https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc#newcode1197
src/mark-compact.cc:1197: void
CodeFlusher::EvictOptimizedCodeMap(SharedFunctionInfo* code_map_holder) {
On 2013/06/11 14:07:17, Hannes Payer wrote:
> Do you want to add tracing support to this function as well?

Done.

[Hannes Payer (out of office), 2013-06-11 14:34:53]

LGTM

[Michael Starzinger, 2013-06-11 14:40:50]

Committed patchset #2 manually as r15064 (presubmit successful).