Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1677273003: Check for null intent when creating notification. (Closed)

Created:
4 years, 10 months ago by aberent
Modified:
4 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for null intent when creating notification. Custom tabs cannot be foregrounded so we can't create an intent in that case. BUG=585402 Committed: https://crrev.com/44a0f0ff0607d3f2c658deec7f395398a398bcf4 Cr-Commit-Position: refs/heads/master@{#374638}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO for Anton. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
aberent
4 years, 10 months ago (2016-02-09 14:27:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677273003/1
4 years, 10 months ago (2016-02-09 14:27:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 15:22:54 UTC) #6
whywhat
lgtm https://codereview.chromium.org/1677273003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/1677273003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java#newcode591 chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:591: mNotificationBuilder.setContentIntent(PendingIntent.getActivity(mContext, 0, Can you add a TODO(avayvod) to ...
4 years, 10 months ago (2016-02-09 19:59:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677273003/20001
4 years, 10 months ago (2016-02-10 10:36:54 UTC) #10
aberent
https://codereview.chromium.org/1677273003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/1677273003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java#newcode591 chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:591: mNotificationBuilder.setContentIntent(PendingIntent.getActivity(mContext, 0, On 2016/02/09 19:59:27, whywhat wrote: > Can ...
4 years, 10 months ago (2016-02-10 10:38:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 11:16:21 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 11:17:52 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44a0f0ff0607d3f2c658deec7f395398a398bcf4
Cr-Commit-Position: refs/heads/master@{#374638}

Powered by Google App Engine
This is Rietveld 408576698