Check for null intent when creating notification.

Check for null intent when creating notification.

Custom tabs cannot be foregrounded so we can't create an intent in that
case.

BUG=585402
Committed: https://crrev.com/44a0f0ff0607d3f2c658deec7f395398a398bcf4
Cr-Commit-Position: refs/heads/master@{#374638}

[aberent, 2016-02-09 14:27:19]

aberent@chromium.org changed reviewers:
+ avayvod@chromium.org, mlamouri@chromium.org

[aberent, 2016-02-09 14:27:50]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 14:27:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1677273003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1677273003/1

[commit-bot: I haz the power, 2016-02-09 15:22:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 15:22:54]

Dry run: This issue passed the CQ dry run.

[whywhat, 2016-02-09 19:59:28]

lgtm

https://codereview.chromium.org/1677273003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
(right):

https://codereview.chromium.org/1677273003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:591:
mNotificationBuilder.setContentIntent(PendingIntent.getActivity(mContext, 0,
Can you add a TODO(avayvod) to figure out what would be the best intent to send
for the custom tabs, etc? There's a related bug:
https://code.google.com/p/chromium/issues/detail?id=585395 you can reference in
the TODO as well.

[aberent, 2016-02-10 10:36:20]

The CQ bit was checked by aberent@chromium.org

[aberent, 2016-02-10 10:36:20]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1677273003/#ps20001
(title: "Add TODO for Anton.")

[commit-bot: I haz the power, 2016-02-10 10:36:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1677273003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1677273003/20001

[aberent, 2016-02-10 10:38:11]

https://codereview.chromium.org/1677273003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
(right):

https://codereview.chromium.org/1677273003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:591:
mNotificationBuilder.setContentIntent(PendingIntent.getActivity(mContext, 0,
On 2016/02/09 19:59:27, whywhat wrote:
> Can you add a TODO(avayvod) to figure out what would be the best intent to
send
> for the custom tabs, etc? There's a related bug:
> https://code.google.com/p/chromium/issues/detail?id=585395 you can reference
in
> the TODO as well.

Done.

[commit-bot: I haz the power, 2016-02-10 11:16:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-10 11:17:51]

Description was changed from

==========
Check for null intent when creating notification.

Custom tabs cannot be foregrounded so we can't create an intent in that
case.

BUG=585402
==========

to

==========
Check for null intent when creating notification.

Custom tabs cannot be foregrounded so we can't create an intent in that
case.

BUG=585402

Committed: https://crrev.com/44a0f0ff0607d3f2c658deec7f395398a398bcf4
Cr-Commit-Position: refs/heads/master@{#374638}
==========

[commit-bot: I haz the power, 2016-02-10 11:17:52]

Patchset 2 (id:??) landed as
https://crrev.com/44a0f0ff0607d3f2c658deec7f395398a398bcf4
Cr-Commit-Position: refs/heads/master@{#374638}