Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1677253002: Add bench and gm for shapes (Closed)

Created:
4 years, 10 months ago by Chris Dalton
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : update dependencies #

Patch Set 3 : incorporate changes from Brian Osman #

Patch Set 4 : More touchups #

Patch Set 5 : Remove unneeded dependency #

Patch Set 6 : MSVC warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -0 lines) Patch
A bench/ShapesBench.cpp View 1 2 3 4 5 1 chunk +289 lines, -0 lines 0 comments Download
A gm/shapes.cpp View 1 2 3 1 chunk +164 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Chris Dalton
https://codereview.chromium.org/1677253002/diff/1/bench/ShapesBench.cpp File bench/ShapesBench.cpp (right): https://codereview.chromium.org/1677253002/diff/1/bench/ShapesBench.cpp#newcode25 bench/ShapesBench.cpp:25: DEFINE_bool(shapesPersp, false, "Use slight perspective tilt in ShapesBench?"); This ...
4 years, 10 months ago (2016-02-08 20:49:18 UTC) #3
joshualitt
On 2016/02/08 20:49:18, Chris Dalton wrote: > https://codereview.chromium.org/1677253002/diff/1/bench/ShapesBench.cpp > File bench/ShapesBench.cpp (right): > > https://codereview.chromium.org/1677253002/diff/1/bench/ShapesBench.cpp#newcode25 ...
4 years, 10 months ago (2016-02-10 19:55:24 UTC) #4
Chris Dalton
Comments added. Is that about what you were looking for?
4 years, 10 months ago (2016-02-10 21:01:38 UTC) #7
joshualitt
On 2016/02/10 21:01:38, Chris Dalton wrote: > Comments added. Is that about what you were ...
4 years, 10 months ago (2016-02-10 21:02:42 UTC) #8
Brian Osman
lgtm
4 years, 10 months ago (2016-02-10 21:12:43 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 1673093002 Patch 60001). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-10 21:25:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677253002/80001
4 years, 10 months ago (2016-02-10 21:33:42 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/6125)
4 years, 10 months ago (2016-02-10 21:36:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677253002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677253002/100001
4 years, 10 months ago (2016-02-10 22:25:27 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 22:54:25 UTC) #22
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/4a6e40d9d2e0eb81e00d8b2bd20532aa28f61afb

Powered by Google App Engine
This is Rietveld 408576698