Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 167723002: Don't display multi-profile under Guest user. (Closed)

Created:
6 years, 10 months ago by bcwhite
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Don't display multi-profile under Guest user. Some settings make sense, even for Guest, but the profile management section should not be available. BUG=285347 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251861

Patch Set 1 #

Patch Set 2 : determine desktop-type inside function now that web_ui() is accessible #

Patch Set 3 : determine desktop-type inside function now that web_ui() is accessible #

Patch Set 4 : allow re-hiding managed-user message #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M chrome/browser/resources/options/browser_options.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 4 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bcwhite
6 years, 10 months ago (2014-02-14 21:52:10 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-15 23:52:04 UTC) #2
bcwhite
The CQ bit was checked by bcwhite@chromium.org
6 years, 10 months ago (2014-02-18 17:02:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/167723002/150001
6 years, 10 months ago (2014-02-18 17:02:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/167723002/150001
6 years, 10 months ago (2014-02-18 18:21:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/167723002/150001
6 years, 10 months ago (2014-02-18 18:29:38 UTC) #6
bcwhite
The CQ bit was checked by bcwhite@chromium.org
6 years, 10 months ago (2014-02-18 19:44:54 UTC) #7
commit-bot: I haz the power
Failed to trigger a try job on win_rel HTTP Error 400: Bad Request
6 years, 10 months ago (2014-02-18 20:13:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/167723002/400001
6 years, 10 months ago (2014-02-18 20:13:43 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 22:29:17 UTC) #10
Message was sent while issue was closed.
Change committed as 251861

Powered by Google App Engine
This is Rietveld 408576698