Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 1677193002: Revert of Add --output-directory to stack tool buildbot step (Closed)

Created:
4 years, 10 months ago by flackr
Modified:
4 years, 10 months ago
Reviewers:
jbudorick, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add --output-directory to stack tool buildbot step (patchset #1 id:1 of https://codereview.chromium.org/1674683002/ ) Reason for revert: This has is failing 'Run stack tool with logcat dump' step on several android bots: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29/builds/6322 https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/5689 Original issue's description: > Add --output-directory to stack tool buildbot step > > BUG=573345 > > Committed: https://crrev.com/ec0616bfa85b1af5369766ee9dad95e69cfe1f7a > Cr-Commit-Position: refs/heads/master@{#374136} TBR=jbudorick@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=573345 Committed: https://crrev.com/a48994189ee90cee5af23727a60d530461a6d678 Cr-Commit-Position: refs/heads/master@{#374154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
flackr
Created Revert of Add --output-directory to stack tool buildbot step
4 years, 10 months ago (2016-02-08 19:29:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677193002/1
4 years, 10 months ago (2016-02-08 19:35:52 UTC) #2
agrieve
On 2016/02/08 19:35:52, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 10 months ago (2016-02-08 19:39:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 19:42:35 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a48994189ee90cee5af23727a60d530461a6d678 Cr-Commit-Position: refs/heads/master@{#374154}
4 years, 10 months ago (2016-02-08 19:43:26 UTC) #6
agrieve
4 years, 10 months ago (2016-02-09 16:29:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1681143002/ by agrieve@chromium.org.

The reason for reverting is: creating CL to reland.

Powered by Google App Engine
This is Rietveld 408576698