Implemented parsing of HEVC codec ids

media/mojo/interfaces/media_types.mojom

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module media.interfaces;
 
 import "ui/mojo/geometry/geometry.mojom";
 
 // See media/base/buffering_state.h for descriptions.
 // Kept in sync with media::BufferingState via static_asserts.
@@ skipping 130 matching lines @@
   Max = HEVC,
 };
 
 // See media/base/video_decoder_config.h for descriptions.
 // Kept in sync with media::VideoCodecProfile via static_asserts.
 enum VideoCodecProfile {
   VIDEO_CODEC_PROFILE_UNKNOWN = -1,
   VIDEO_CODEC_PROFILE_MIN = VIDEO_CODEC_PROFILE_UNKNOWN,
   H264PROFILE_MIN = 0,
   H264PROFILE_BASELINE = H264PROFILE_MIN,
-  H264PROFILE_MAIN = 1,
-  H264PROFILE_EXTENDED = 2,
-  H264PROFILE_HIGH = 3,
-  H264PROFILE_HIGH10PROFILE = 4,
-  H264PROFILE_HIGH422PROFILE = 5,
-  H264PROFILE_HIGH444PREDICTIVEPROFILE = 6,
-  H264PROFILE_SCALABLEBASELINE = 7,
-  H264PROFILE_SCALABLEHIGH = 8,
-  H264PROFILE_STEREOHIGH = 9,
-  H264PROFILE_MULTIVIEWHIGH = 10,
+  H264PROFILE_MAIN,

[ddorwin, 2016/03/02 01:36:38]

Since this is a MOJO API definition, I wonder whether values are allowed to
change. It seems we have a mix. I wonder why.

[servolk, 2016/03/02 01:47:45]

Is there a requirement that constants never change in Mojo API? I assumed Mojo
values might change, although of course that would make it necessary to rebuild
also clients that use this .mojom file.

[xhwang, 2016/03/02 04:17:55]

At this point mojo is pretty much just a transport layer to replace the hassle
of IPC. The mojo media app is shipped within Chrome and is not a standalone
binary, so we can change these constants freely. This may not be true in the
future where the mojo media app (or some other app that uses this) becomes a
separate binary.

+  H264PROFILE_EXTENDED,
+  H264PROFILE_HIGH,
+  H264PROFILE_HIGH10PROFILE,
+  H264PROFILE_HIGH422PROFILE,
+  H264PROFILE_HIGH444PREDICTIVEPROFILE,
+  H264PROFILE_SCALABLEBASELINE,
+  H264PROFILE_SCALABLEHIGH,
+  H264PROFILE_STEREOHIGH,
+  H264PROFILE_MULTIVIEWHIGH,
   H264PROFILE_MAX = H264PROFILE_MULTIVIEWHIGH,
-  VP8PROFILE_MIN = 11,
+  VP8PROFILE_MIN,
   VP8PROFILE_ANY = VP8PROFILE_MIN,
   VP8PROFILE_MAX = VP8PROFILE_ANY,
-  VP9PROFILE_MIN = 12,
+  VP9PROFILE_MIN,
   VP9PROFILE_ANY = VP9PROFILE_MIN,
   VP9PROFILE_MAX = VP9PROFILE_ANY,
-  VIDEO_CODEC_PROFILE_MAX = VP9PROFILE_MAX,
+  // 4 profile values are reserved for VP9 profiles.
+  HEVCPROFILE_MIN = 16,

[ddorwin, 2016/03/02 01:36:38]

not done. There are no other literals here.

[servolk, 2016/03/02 01:47:45]

I think this is the best we can do. I've tried to have HEVCPROFILE_MIN =
VP9PROFILE_ANY + 4 here in patchset #20. But that caused a number of build
failures. Apparently mojom files don't allow expressions, so I've changed this
to an explicit value for now.

Here is the build error from PS #20:
FAILED: python ../../mojo/public/tools/bindings/mojom_bindings_generator.py
--use_bundled_pylibs generate ../../media/mojo/interfaces/renderer.mojom -d
../../ -I ../../ -o /b/build/slave/linux_clobber/build/src/out/Release/gen
--bytecode_path
/b/build/slave/linux_clobber/build/src/out/Release/gen/mojo/public/tools/bindings
-g c++,javascript,java
../../media/mojo/interfaces/media_types.mojom:169: Error: Unexpected '+':
  HEVCPROFILE_MIN = VP9PROFILE_ANY + 4, //=16

[ddorwin, 2016/03/03 22:00:21]

Longshot - does it work if you use parentheses?

That looks like a tooling bug. I suggest filing a bug in the Internals>Mojo
component. For now, we can define RESERVED1-4 and add a comment referencing that
bug.

+  HEVCPROFILE_MAIN = HEVCPROFILE_MIN,
+  HEVCPROFILE_MAIN10,
+  HEVCPROFILE_MAIN_STILL_PICTURE,
+  HEVCPROFILE_MAX = HEVCPROFILE_MAIN_STILL_PICTURE,
+  VIDEO_CODEC_PROFILE_MAX = HEVCPROFILE_MAX,
 };
 
 // This defines a mojo transport format for media::AudioDecoderConfig.
 // See media/base/audio_decoder_config.h for descriptions.
 struct AudioDecoderConfig {
   AudioCodec codec;
   SampleFormat sample_format;
   ChannelLayout channel_layout;
   int32 samples_per_second;
   array<uint8>? extra_data;
@@ skipping 106 matching lines @@
   bool end_of_stream;
 
   // Timestamp in microseconds of the associated frame.
   int64 timestamp_usec;
 
   // Frame data for each plane. Will be null for EOS buffers.
   array<uint8>? y_data;
   array<uint8>? u_data;
   array<uint8>? v_data;
 };