Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: runtime/bin/vmservice/client/deployed/web/index_devtools.html

Issue 167713002: Improved how closures are displayed by <instance-ref>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/deployed/web/index_devtools.html
diff --git a/runtime/bin/vmservice/client/deployed/web/index_devtools.html b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
index a0bdcf415b3b4bf9fa8e37b5b6c9b9d2e8660dc9..f69ea29b65815a9569ba702d56a009593c3a207e 100644
--- a/runtime/bin/vmservice/client/deployed/web/index_devtools.html
+++ b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
@@ -98,6 +98,12 @@
<a href="{{ url }}">{{ name }}</a>
</template>
+ <template if="{{ isClosureRef(ref['type']) }}">
+ <a href="{{ url }}">
+ {{ ref['closureFunc']['user_name'] }}
+ </a>
+ </template>
+
<template if="{{ isInstanceRef(ref['type']) }}">
<a href="{{ url }}"><em>{{ ref['class']['user_name'] }}</em></a> {
<a on-click="{{ toggleExpand }}">...</a>
@@ -770,6 +776,9 @@
<template if="{{ messageType == 'Field' }}">
<field-view app="{{ app }}" field="{{ message }}"></field-view>
</template>
+ <template if="{{ messageType == 'Closure' }}">
+ <instance-view app="{{ app }}" instance="{{ message }}"></instance-view>
+ </template>
<template if="{{ messageType == 'Instance' }}">
<instance-view app="{{ app }}" instance="{{ message }}"></instance-view>
</template>
@@ -806,7 +815,8 @@
<!-- Add new views and message types in the future here. -->
</template>
-</polymer-element><polymer-element name="navigation-bar-isolate" extends="observatory-element">
+</polymer-element>
+<polymer-element name="navigation-bar-isolate" extends="observatory-element">
<template>
<ul class="nav navbar-nav">
<li><a href="{{ currentIsolateLink('') }}"> {{currentIsolateName()}}</a></li>

Powered by Google App Engine
This is Rietveld 408576698