Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 16771002: Test that functions created using v8::FunctionTemplate::New correctly displayed in CPU profiles (Closed)

Created:
7 years, 6 months ago by yurys
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Test that functions created using v8::FunctionTemplate::New correctly displayed in CPU profiles BUG=244580 R=jkummerow@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15066

Patch Set 1 #

Patch Set 2 : Removed unused var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -12 lines) Patch
M test/cctest/test-cpu-profiler.cc View 1 6 chunks +131 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 6 months ago (2013-06-11 11:12:41 UTC) #1
loislo
lgtm
7 years, 6 months ago (2013-06-11 13:08:54 UTC) #2
Jakob Kummerow
rubberstamp LGTM
7 years, 6 months ago (2013-06-11 14:47:03 UTC) #3
yurys
7 years, 6 months ago (2013-06-11 15:00:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698