components/ntp_snippets/ntp_snippet.h - Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippet.h

Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/ntp_snippet.h

diff --git a/components/ntp_snippets/ntp_snippet.h b/components/ntp_snippets/ntp_snippet.h

index 6ea126abd1f9f8ecf31291d8511fed88a0404c42..6dd2ad045bc64ab617cf2b893284aed0cd6ce09f 100644

--- a/components/ntp_snippets/ntp_snippet.h

+++ b/components/ntp_snippets/ntp_snippet.h

@@ -4,7 +4,6 @@

#ifndef COMPONENTS_NTP_SNIPPETS_NTP_SNIPPET_H_

#define COMPONENTS_NTP_SNIPPETS_NTP_SNIPPET_H_

-#include <memory>

#include <string>

#include "base/macros.h"

@@ -30,7 +29,7 @@ class NTPSnippet {

// dictionary doesn't contain at least a url. The keys in the dictionary are

// expected to be the same as the property name, with exceptions documented in

// the property comment.

- static std::unique_ptr<NTPSnippet> NTPSnippetFromDictionary(

+ static scoped_ptr<NTPSnippet> NTPSnippetFromDictionary(

const base::DictionaryValue& dict);

// URL of the page described by this snippet.

« no previous file with comments | « components/ntp_snippets/DEPS ('k') | components/ntp_snippets/ntp_snippet.cc » ('j') | no next file with comments »