chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleaning up Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/NTPSnippetsBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index 876517020d8d4fb9bd362ad1d46ff8914408a664..ff9d4cce92ef3a9d4ea5d889b5067e61e06d1b37 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -47,6 +47,7 @@ import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;

import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;

import org.chromium.chrome.browser.ntp.interests.InterestsPage;

import org.chromium.chrome.browser.ntp.interests.InterestsPage.InterestsClickListener;

+import org.chromium.chrome.browser.ntp.snippets.SnippetsManager;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;

import org.chromium.chrome.browser.preferences.DocumentModeManager;

@@ -579,7 +580,7 @@ public class NewTabPage

LayoutInflater inflater = LayoutInflater.from(activity);

mNewTabPageView = (NewTabPageView) inflater.inflate(R.layout.new_tab_page, null);

mNewTabPageView.initialize(mNewTabPageManager, isInSingleUrlBarMode(activity),

- mSearchProviderHasLogo);

+ mSearchProviderHasLogo, new SnippetsManager(mNewTabPageManager, mProfile));

mIsTablet = DeviceFormFactor.isTablet(activity);