chrome/chrome_browser.gypi - Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR comments, modified iOS NTPSnippetServiceFactory Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc ('k') | components/ntp_snippets.gypi » ('j') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 777274c6f9ef0bd11d0eaaa2c9c92ae9f8f46d88..45a9ae8869773c922df484429acb5b8ccc0a8641 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -829,6 +829,10 @@

'browser/android/new_tab_page_prefs.h',

'browser/android/new_tab_page_url_handler.cc',

'browser/android/new_tab_page_url_handler.h',

+ 'browser/android/ntp_snippets_bridge.cc',

+ 'browser/android/ntp_snippets_bridge.h',

+ 'browser/android/ntp_snippets_controller.cc',

+ 'browser/android/ntp_snippets_controller.h',

'browser/android/omnibox/answers_image_bridge.cc',

'browser/android/omnibox/answers_image_bridge.h',

'browser/android/omnibox/autocomplete_controller_android.cc',

@@ -1871,10 +1875,12 @@

'android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java',

'android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java',

'android/java/src/org/chromium/chrome/browser/ntp/ForeignSessionHelper.java',

+ 'android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsService.java',

'android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java',

'android/java/src/org/chromium/chrome/browser/ntp/NewTabPagePrefs.java',

'android/java/src/org/chromium/chrome/browser/ntp/RecentlyClosedBridge.java',

- 'android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsService.java',

+ 'android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java',

+ 'android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java',

'android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java',

'android/java/src/org/chromium/chrome/browser/omnibox/AnswersImage.java',

'android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java',