chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR comments, modified iOS NTPSnippetServiceFactory Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index ddd8f973e83fa2bb9b21f0c8cfe9c7889cf69618..10d98a246449ad8529879a426e9b3bd70a77222d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -89,6 +89,7 @@ import org.chromium.chrome.browser.metrics.StartupMetrics;

import org.chromium.chrome.browser.metrics.UmaSessionStats;

import org.chromium.chrome.browser.nfc.BeamController;

import org.chromium.chrome.browser.nfc.BeamProvider;

+import org.chromium.chrome.browser.ntp.snippets.SnippetsController;

import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;

import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;

import org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup;

@@ -690,6 +691,12 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

mToolbarManager.onDeferredStartup(getOnCreateTimestampMs(), simpleName);

}

recordKeyboardLocaleUma();

+ // TODO(treib): Remove this when we have the proper morning reads fetching logic in place

+ if (CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_NTP_SNIPPETS)) {

+ // Initialize snippets

+ SnippetsController.get(this).fetchSnippets(false);

+ }

}

@Override

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('J')