Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: chrome/browser/android/ntp_snippets_bridge.cc

Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/android/ntp_snippets_bridge.h"
6
7 #include <jni.h>
8
9 #include "base/android/jni_android.h"
10 #include "base/android/jni_array.h"
11 #include "base/android/scoped_java_ref.h"
12 #include "chrome/browser/ntp_snippets/ntp_snippets_service_factory.h"
13 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/profiles/profile_android.h"
15 #include "components/ntp_snippets/ntp_snippets_service.h"
16 #include "jni/SnippetsBridge_jni.h"
17
18 using base::android::JavaParamRef;
19 using base::android::ToJavaArrayOfStrings;
20
21 static jlong Init(JNIEnv* env,
22 const JavaParamRef<jobject>& obj,
23 const JavaParamRef<jobject>& j_profile) {
24 NTPSnippetsBridge* snippets_bridge = new NTPSnippetsBridge(j_profile);
25 return reinterpret_cast<intptr_t>(snippets_bridge);
26 }
27
28 NTPSnippetsBridge::NTPSnippetsBridge(jobject j_profile)
29 : snippet_service_observer_(this) {
30 Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);
31 if (profile) {
32 ntp_snippets_service_ = NTPSnippetsServiceFactory::GetForProfile(profile);
33 snippet_service_observer_.Add(ntp_snippets_service_);
34 }
35 }
36
37 NTPSnippetsBridge::~NTPSnippetsBridge() {}
38
39 void NTPSnippetsBridge::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {
40 delete this;
41 }
42
43 void NTPSnippetsBridge::SetSnippetsObserver(
44 JNIEnv* env,
45 const JavaParamRef<jobject>& obj,
46 const JavaParamRef<jobject>& j_observer) {
47 observer_.Reset(env, j_observer);
48 if (ntp_snippets_service_->is_loaded())
49 NTPSnippetsServiceLoaded(ntp_snippets_service_);
50 }
51
52 void NTPSnippetsBridge::NTPSnippetsServiceLoaded(NTPSnippetsService* service) {
53 if (observer_.is_null())
54 return;
55
56 std::vector<std::string> titles;
57 std::vector<std::string> urls;
58 std::vector<std::string> thumbnail_urls;
59 std::vector<std::string> snippets;
60 for (const auto& snippet : *service) {
61 titles.push_back(snippet.title());
62 urls.push_back(snippet.url().spec());
63 thumbnail_urls.push_back(snippet.salient_image_url().spec());
64 snippets.push_back(snippet.snippet());
65 }
66
67 JNIEnv* env = base::android::AttachCurrentThread();
68 Java_SnippetsObserver_onSnippetsAvailable(
69 env, observer_.obj(), ToJavaArrayOfStrings(env, titles).obj(),
70 ToJavaArrayOfStrings(env, urls).obj(),
71 ToJavaArrayOfStrings(env, thumbnail_urls).obj(),
72 ToJavaArrayOfStrings(env, snippets).obj());
73 }
74
75 void NTPSnippetsBridge::NTPSnippetsServiceShutdown(
76 NTPSnippetsService* service) {
77 observer_.Reset();
Bernhard Bauer 2016/02/10 10:48:44 You might want to remove the service from the |sni
May 2016/02/10 18:16:46 Done.
78 }
79
80 // static
81 bool NTPSnippetsBridge::RegisterNTPSnippetsBridge(JNIEnv* env) {
82 return RegisterNativesImpl(env);
83 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698