Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 1677063005: Revert of [builtins] Remove bunch of uses of %_Arguments and %_ArgumentsLength. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Remove bunch of uses of %_Arguments and %_ArgumentsLength. (patchset #1 id:1 of https://codereview.chromium.org/1678953004/ ) Reason for revert: Breaks tree Original issue's description: > [builtins] Remove bunch of uses of %_Arguments and %_ArgumentsLength. > > There are a bunch of places in our builtins where we use %_Arguments and > %_ArgumentsLength for no good reason, as arguments object and/or rest > parameter is as good and performant in these cases. Now the only uses > of %_Arguments and %_ArgumentsLength left are in string.js, which > requires dedicated investigation. > > R=yangguo@chromium.org > > Committed: https://crrev.com/2160429fd458e3c095475e718c97f77ac90d906f > Cr-Commit-Position: refs/heads/master@{#33834} TBR=yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/dca275bac9a625447585b09fda0fd34cb6fca874 Cr-Commit-Position: refs/heads/master@{#33835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -34 lines) Patch
M src/js/array.js View 14 chunks +20 lines, -20 lines 0 comments Download
M src/js/json.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/spread.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/js/typedarray.js View 6 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
Created Revert of [builtins] Remove bunch of uses of %_Arguments and %_ArgumentsLength.
4 years, 10 months ago (2016-02-09 08:02:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677063005/1
4 years, 10 months ago (2016-02-09 08:02:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 08:02:46 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 08:03:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dca275bac9a625447585b09fda0fd34cb6fca874
Cr-Commit-Position: refs/heads/master@{#33835}

Powered by Google App Engine
This is Rietveld 408576698