Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: runtime/vm/cpuid.h

Issue 1677043003: 1. Fix memory leaks reported by running a simple test using ASAN (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address-code-review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/cpuinfo.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_CPUID_H_ 5 #ifndef VM_CPUID_H_
6 #define VM_CPUID_H_ 6 #define VM_CPUID_H_
7 7
8 #include "vm/globals.h" 8 #include "vm/globals.h"
9 #if !defined(TARGET_OS_MACOS) 9 #if !defined(TARGET_OS_MACOS)
10 #include "vm/allocation.h" 10 #include "vm/allocation.h"
11 #include "vm/cpuinfo.h" 11 #include "vm/cpuinfo.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 class CpuId : public AllStatic { 15 class CpuId : public AllStatic {
16 public: 16 public:
17 #if defined(HOST_ARCH_IA32) || defined(HOST_ARCH_X64) 17 #if defined(HOST_ARCH_IA32) || defined(HOST_ARCH_X64)
18 static void InitOnce(); 18 static void InitOnce();
19 static void Cleanup(); 19 static void Cleanup();
20 20
21 // Caller must free the result of field. 21 // Caller must free the result of field.
22 static const char* field(CpuInfoIndices idx); 22 static const char* field(CpuInfoIndices idx);
23 #else 23 #else
24 static void InitOnce() {} 24 static void InitOnce() {}
25 static void Cleanup() {} 25 static void Cleanup() {}
26 static const char* field(CpuInfoIndices idx) { return NULL; } 26 static const char* field(CpuInfoIndices idx) { return NULL; }
27 #endif 27 #endif
28 28
29 private:
30 // Caller must free the result of id_string and brand_string.
31 static const char* id_string();
32 static const char* brand_string();
33
29 static bool sse2() { return sse2_; } 34 static bool sse2() { return sse2_; }
30 static bool sse41() { return sse41_; } 35 static bool sse41() { return sse41_; }
31 36
32 // Caller must free the result of id_string and brand_string.
33 static const char* id_string();
34 static const char* brand_string();
35
36 private:
37 static bool sse2_; 37 static bool sse2_;
38 static bool sse41_; 38 static bool sse41_;
39 static const char* id_string_; 39 static const char* id_string_;
40 static const char* brand_string_; 40 static const char* brand_string_;
41 41
42 static void GetCpuId(int32_t level, uint32_t info[4]); 42 static void GetCpuId(int32_t level, uint32_t info[4]);
43 }; 43 };
44 44
45 } // namespace dart 45 } // namespace dart
46 46
47 #endif // !defined(TARGET_OS_MACOS) 47 #endif // !defined(TARGET_OS_MACOS)
48 #endif // VM_CPUID_H_ 48 #endif // VM_CPUID_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/cpuinfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698