base/logging.cc - Issue 16770006: Implement basic stack traces on Android and reenable unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.cc

Issue 16770006: Implement basic stack traces on Android and reenable unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: refactor symbolize Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.cc

diff --git a/base/logging.cc b/base/logging.cc

index 4800f82e203125f7e04eea9f02b46a940564dd77..99bfdaf89a5f430af1afc3bb19a4282953f64d61 100644

--- a/base/logging.cc

+++ b/base/logging.cc

@@ -564,9 +564,7 @@ LogMessage::LogMessage(const char* file, int line, LogSeverity severity,

}

LogMessage::~LogMessage() {

- // TODO(port): enable stacktrace generation on LOG_FATAL once backtrace are

- // working in Android.

-#if !defined(NDEBUG) && !defined(OS_ANDROID) && !defined(OS_NACL)

+#if !defined(NDEBUG) && !defined(OS_NACL)

if (severity_ == LOG_FATAL) {

// Include a stack trace on a fatal.

base::debug::StackTrace trace;