base/debug/stack_trace_unittest.cc - Issue 16770006: Implement basic stack traces on Android and reenable unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/stack_trace_unittest.cc

Issue 16770006: Implement basic stack traces on Android and reenable unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixes Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/stack_trace_unittest.cc

diff --git a/base/debug/stack_trace_unittest.cc b/base/debug/stack_trace_unittest.cc

index d2901815725c6187beaa159cbeb847699369a1b5..42c662864170f7e01c808cff03d015d6a4d1c7d5 100644

--- a/base/debug/stack_trace_unittest.cc

+++ b/base/debug/stack_trace_unittest.cc

@@ -126,7 +126,13 @@ TEST_F(StackTraceTest, DebugOutputToStream) {

}

// The test is used for manual testing, e.g., to see the raw output.

-TEST_F(StackTraceTest, DebugPrintBacktrace) {

+// Android implementation crashes due to SIGSTKFLT http://crbug.com/248775

+#if defined(OS_ANDROID)

+#define MAYBE_DebugPrintBacktrace DISABLED_DebugPrintBacktrace

+#else

+#define MAYBE_DebugPrintBacktrace DebugPrintBacktrace

+#endif

+TEST_F(StackTraceTest, MAYBE_DebugPrintBacktrace) {

StackTrace().PrintBacktrace();

}