OLD | NEW |
1 Tree Sheriffs Documentation | 1 Tree Sheriffs Documentation |
2 =========================== | 2 =========================== |
3 | 3 |
4 ### Contents ### | 4 ### Contents ### |
5 | 5 |
6 * [What does a sheriff do?](#what_is_a_sheriff) | 6 * [What does a sheriff do?](#what_is_a_sheriff) |
7 + [Skia tree](#skia_tree) | 7 + [Skia tree](#skia_tree) |
8 + [DEPS rolls](#deps_rolls) | 8 + [DEPS rolls](#deps_rolls) |
9 + [Gold and Perf](#gold_and_perf) | 9 + [Gold and Perf](#gold_and_perf) |
10 + [Documentation](#sheriff_doc) | 10 + [Documentation](#sheriff_doc) |
(...skipping 20 matching lines...) Expand all Loading... |
31 ### Skia tree | 31 ### Skia tree |
32 * Understand the [buildbots infrastructure](https://skia.org/dev/testing/buildbo
t). | 32 * Understand the [buildbots infrastructure](https://skia.org/dev/testing/buildbo
t). |
33 * Start watching the [status page](https://status.skia.org) for bot breakages. | 33 * Start watching the [status page](https://status.skia.org) for bot breakages. |
34 * Track down people responsible for breakages and revert broken changes if there
is no easy fix. | 34 * Track down people responsible for breakages and revert broken changes if there
is no easy fix. |
35 * Close and open the [tree](http://skia-tree-status.appspot.com). | 35 * Close and open the [tree](http://skia-tree-status.appspot.com). |
36 * Keep the builder comments on the [status page](https://status.skia.org) up to
date. | 36 * Keep the builder comments on the [status page](https://status.skia.org) up to
date. |
37 * File or follow up with [BreakingTheBuildbots bugs](https://bug.skia.org/?q=lab
el:BreakingTheBuildbots). See the tip on [when to file bugs](#when_to_file_bugs)
. | 37 * File or follow up with [BreakingTheBuildbots bugs](https://bug.skia.org/?q=lab
el:BreakingTheBuildbots). See the tip on [when to file bugs](#when_to_file_bugs)
. |
38 | 38 |
39 <a name="deps_rolls"></a> | 39 <a name="deps_rolls"></a> |
40 ### DEPS rolls | 40 ### DEPS rolls |
41 * Ensure that [AutoRoll Bot](https://skia-tree-status.appspot.com/set_arb_action
)'s DEPS rolls land successfully. | 41 * Ensure that [AutoRoll Bot](https://autoroll.skia.org)'s DEPS rolls land succes
sfully. |
42 | 42 |
43 <a name="gold_and_perf"></a> | 43 <a name="gold_and_perf"></a> |
44 ### Gold and Perf | 44 ### Gold and Perf |
45 * Pay attention for new [Perf](https://perf.skia.org/) and [Gold](https://gold.s
kia.org/) alerts (by clicking on the bell at the top right of the [status page](
https://status.skia.org)). | 45 * Pay attention for new [Perf](https://perf.skia.org/) and [Gold](https://gold.s
kia.org/) alerts (by clicking on the bell at the top right of the [status page](
https://status.skia.org)). |
46 * The sheriff's duty here is to make sure that when developers introduce new ima
ges or new perf regressions, that they are aware of what happened, and they use
these tools to take appropriate action. | 46 * The sheriff's duty here is to make sure that when developers introduce new ima
ges or new perf regressions, that they are aware of what happened, and they use
these tools to take appropriate action. |
47 | 47 |
48 <a name="sheriff_doc"></a> | 48 <a name="sheriff_doc"></a> |
49 ### Documentation | 49 ### Documentation |
50 * Improve/update this documentation page for future sheriffs, especially the [Ti
ps section](#tips). | 50 * Improve/update this documentation page for future sheriffs, especially the [Ti
ps section](#tips). |
51 | 51 |
52 In general, sheriffs should have a strong bias towards actions that keep the tre
e green and then open; if a simple revert can fix the problem, the sheriff <b>sh
ould revert first and ask questions later</b>. | 52 In general, sheriffs should have a strong bias towards actions that keep the tre
e green and then open; if a simple revert can fix the problem, the sheriff <b>sh
ould revert first and ask questions later</b>. |
53 | 53 |
54 | 54 |
55 <a name="view_current_upcoming_sheriffs"></a> | 55 <a name="view_current_upcoming_sheriffs"></a> |
56 View current and upcoming sheriffs | 56 View current and upcoming sheriffs |
57 ---------------------------------- | 57 ---------------------------------- |
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
142 * Note: this change is usually done in the DEPS roll patch itself | 142 * Note: this change is usually done in the DEPS roll patch itself |
143 | 143 |
144 * (Preferred but slower) Make a separate Blink patch by editing LayoutTests/Test
Expectations | 144 * (Preferred but slower) Make a separate Blink patch by editing LayoutTests/Test
Expectations |
145 * Add # comment about what has changed (I usually paraphrase the crbug text) | 145 * Add # comment about what has changed (I usually paraphrase the crbug text) |
146 * Add line(s) like the following after the comment: | 146 * Add line(s) like the following after the comment: |
147 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsManualRebas
eline ] | 147 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsManualRebas
eline ] |
148 * Commit the patch you created and wait until it lands and rolls into Chrome | 148 * Commit the patch you created and wait until it lands and rolls into Chrome |
149 | 149 |
150 * Retry the DEPS roll (for the 1st/dispreferred option this usually means just r
etrying the layout bots) | 150 * Retry the DEPS roll (for the 1st/dispreferred option this usually means just r
etrying the layout bots) |
151 * Make a Blink patch by editing LayoutTests/TestExpectations | 151 * Make a Blink patch by editing LayoutTests/TestExpectations |
152 * Add # comment about what has changed | 152 * Add # comment about what has changed |
153 * Add line(s) like the following after the comment: | 153 * Add line(s) like the following after the comment: |
154 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsRebaseline
] | 154 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsRebaseline
] |
155 * (if you took the second option above you can just edit the existing li
ne(s)) | 155 * (if you took the second option above you can just edit the existing li
ne(s)) |
156 | 156 |
157 * If you took the first/dispreferred option above: | 157 * If you took the first/dispreferred option above: |
158 * Wait for the Blink patch to roll into Chrome | 158 * Wait for the Blink patch to roll into Chrome |
159 * Create a Chrome patch that removes your suppressions from skia/skia_test_exp
ectations.txt | 159 * Create a Chrome patch that removes your suppressions from skia/skia_test_exp
ectations.txt |
160 | 160 |
161 | 161 |
OLD | NEW |