Introduce HeapAllocHooks

third_party/WebKit/Source/platform/heap/HeapPage.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1115 matching lines @@
             headerAddress += size;
             continue;
         }
         ASSERT(header->checkHeader());
 
         if (!header->isMarked()) {
             size_t size = header->size();
             // This is a fast version of header->payloadSize().
             size_t payloadSize = size - sizeof(HeapObjectHeader);
             Address payload = header->payload();
+            HeapAllocHooks::freeHookIfEnabled(payload);

[haraken, 2016/02/12 10:29:19]

Can we move this into header->finalize()?

[hajimehoshi, 2016/02/15 07:14:46]

Done.

             // For ASan, unpoison the object before calling the finalizer. The
             // finalized object will be zero-filled and poison'ed afterwards.
             // Given all other unmarked objects are poisoned, ASan will detect
             // an error if the finalizer touches any other on-heap object that
             // die at the same GC cycle.
             ASAN_UNPOISON_MEMORY_REGION(payload, payloadSize);
             header->finalize(payload, payloadSize);
             // This memory will be added to the freelist. Maintain the invariant
             // that memory on the freelist is zero filled.
             SET_MEMORY_INACCESSIBLE(headerAddress, size);
@@ skipping 295 matching lines @@
     return !heapObjectHeader()->isMarked();
 }
 
 void LargeObjectPage::removeFromHeap()
 {
     static_cast<LargeObjectHeap*>(heap())->freeLargeObjectPage(this);
 }
 
 void LargeObjectPage::sweep()
 {
+    HeapAllocHooks::freeHookIfEnabled(payload());

[haraken, 2016/02/12 10:29:19]

Then you can remove this.

[hajimehoshi, 2016/02/15 07:14:46]

Done.

     heapObjectHeader()->unmark();
     Heap::increaseMarkedObjectSize(size());
 }
 
 void LargeObjectPage::makeConsistentForGC()
 {
     HeapObjectHeader* header = heapObjectHeader();
     if (header->isMarked()) {
         header->unmark();
         Heap::increaseMarkedObjectSize(size());
@@ skipping 113 matching lines @@
 
     m_hasEntries = true;
     size_t index = hash(address);
     ASSERT(!(index & 1));
     Address cachePage = roundToBlinkPageStart(address);
     m_entries[index + 1] = m_entries[index];
     m_entries[index] = cachePage;
 }
 
 } // namespace blink