Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1676953003: Cleanup: Remove unused PrintSettings shrink factors. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused PrintSettings shrink factors. - They have been unused for 7 years. - The copy that is being used eventually moved to third_party/WebKit/Source/core/page/PrintContext.cpp. Committed: https://crrev.com/5e8544fc5972711c5237e3bcd8c018a0b439f4f1 Cr-Commit-Position: refs/heads/master@{#374553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -53 lines) Patch
M chrome/test/data/printing/cloud_print_uitest.html View 2 chunks +1 line, -3 lines 0 comments Download
M components/printing/browser/print_manager_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/printing/common/print_messages.h View 2 chunks +0 lines, -8 lines 0 comments Download
M components/printing/common/print_messages.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/printing/test/mock_printer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/printing/test/mock_printer.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M printing/print_settings.h View 2 chunks +0 lines, -17 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M printing/print_settings_conversion.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Lei Zhang
OTOH, I found some shrink factor code that has been dead for years.
4 years, 10 months ago (2016-02-09 19:11:59 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
4 years, 10 months ago (2016-02-09 19:22:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676953003/1
4 years, 10 months ago (2016-02-09 20:48:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144379)
4 years, 10 months ago (2016-02-09 21:01:51 UTC) #7
Lei Zhang
+tsepez for ipc. It's all red.
4 years, 10 months ago (2016-02-09 22:12:29 UTC) #9
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-10 00:29:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676953003/1
4 years, 10 months ago (2016-02-10 00:34:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 00:44:28 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5e8544fc5972711c5237e3bcd8c018a0b439f4f1 Cr-Commit-Position: refs/heads/master@{#374553}
4 years, 10 months ago (2016-02-10 00:45:44 UTC) #15
phoglund_chromium
4 years, 10 months ago (2016-02-15 15:07:03 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1697183002/ by phoglund@chromium.org.

The reason for reverting is: Seems to break printing WebKit Linux MSAN (test
times out):
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b....

Powered by Google App Engine
This is Rietveld 408576698