Table cell background painting

third_party/WebKit/Source/core/layout/LayoutTable.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 710 matching lines @@
 }
 
 LayoutTableSection* LayoutTable::topNonEmptySection() const
 {
     LayoutTableSection* section = topSection();
     if (section && !section->numRows())
         section = sectionBelow(section, SkipEmptySections);
     return section;
 }
 
+LayoutTableSection* LayoutTable::bottomNonEmptySection() const
+{
+    LayoutTableSection* section = bottomSection();
+    if (section && !section->numRows())
+        section = sectionAbove(section, SkipEmptySections);
+    return section;
+}
+
 void LayoutTable::splitColumn(unsigned position, unsigned firstSpan)
 {
     // We split the column at "position", taking "firstSpan" cells from the span.
     ASSERT(m_columns[position].span > firstSpan);
     m_columns.insert(position, ColumnStruct(firstSpan));
     m_columns[position + 1].span -= firstSpan;
 
     // Propagate the change in our columns representation to the sections that don't need
     // cell recalc. If they do, they will be synced up directly with m_columns later.
     for (LayoutObject* child = firstChild(); child; child = child->nextSibling()) {
@@ skipping 90 matching lines @@
                     colAndColGroup.adjoinsStartBorderOfColGroup = isAtStartEdge && !colAndColGroup.col->previousSibling();
                     colAndColGroup.adjoinsEndBorderOfColGroup = isAtEndEdge && !colAndColGroup.col->nextSibling();
                 }
             }
             return colAndColGroup;
         }
     }
     return ColAndColGroup();
 }
 
+// Inverse of slowColElement:
+// maps LayoutTableCol to columnIndex useful for columnPositions
+unsigned LayoutTable::colElementToCol(const LayoutTableCol * colElement) const

[Xianzhu, 2016/02/23 22:58:27]

Nit: extra space before '*'.

[atotic1, 2016/03/15 16:50:47]

Done.

+{
+    unsigned col = 0;
+    unsigned i;
+    for (i = 0; i < m_columnLayoutObjects.size() && col < m_columns.size(); i++) {

[Xianzhu, 2016/02/23 22:58:27]

The col < m_columns.size() seems incorrect. m_columns.size() is the number of
effective columns, not the actual column index that this function is to return.

[Xianzhu, 2016/02/23 22:58:27]

The following style is preferred:
for (const LayoutTableCol* column : m_columnLayoutObjects) {
  ...
}

+        if (colElement == m_columnLayoutObjects[i]) {
+            return col;
+        }
+        if (!m_columnLayoutObjects[i]->isTableColumnGroup())

[Xianzhu, 2016/02/23 22:58:27]

Is this condition correct? It seems different from slowColElement().

+            col += m_columnLayoutObjects[i]->span();
+    }
+
+    return m_columns.size() - 1;
+}
+
 void LayoutTable::recalcSections() const
 {
     ASSERT(m_needsSectionRecalc);
 
     m_head = nullptr;
     m_foot = nullptr;
     m_firstBody = nullptr;
     m_hasColElements = false;
     m_hasCellColspanThatDeterminesTableWidth = hasCellColspanThatDeterminesTableWidth();
 
@@ skipping 604 matching lines @@
 
 LayoutUnit LayoutTable::paddingRight() const
 {
     if (collapseBorders())
         return LayoutUnit();
 
     return LayoutBlock::paddingRight();
 }
 
 } // namespace blink