Table cell background painting

third_party/WebKit/Source/core/layout/LayoutTable.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 716 matching lines @@
 }
 
 LayoutTableSection* LayoutTable::topNonEmptySection() const
 {
     LayoutTableSection* section = topSection();
     if (section && !section->numRows())
         section = sectionBelow(section, SkipEmptySections);
     return section;
 }
 
+LayoutTableSection* LayoutTable::bottomNonEmptySection() const
+{
+    LayoutTableSection* section = bottomSection();
+    if (section && !section->numRows())
+        section = sectionAbove(section, SkipEmptySections);
+    return section;
+}
+
 void LayoutTable::splitEffectiveColumn(unsigned index, unsigned firstSpan)
 {
     // We split the column at |index|, taking |firstSpan| cells from the span.
     ASSERT(m_effectiveColumns[index].span > firstSpan);
     m_effectiveColumns.insert(index, firstSpan);
     m_effectiveColumns[index + 1].span -= firstSpan;
 
     // Propagate the change in our columns representation to the sections that don't need
     // cell recalc. If they do, they will be synced up directly with m_columns later.
     for (LayoutObject* child = firstChild(); child; child = child->nextSibling()) {
@@ skipping 90 matching lines @@
                     colAndColGroup.adjoinsStartBorderOfColGroup = isAtStartEdge && !colAndColGroup.col->previousSibling();
                     colAndColGroup.adjoinsEndBorderOfColGroup = isAtEndEdge && !colAndColGroup.col->nextSibling();
                 }
             }
             return colAndColGroup;
         }
     }
     return ColAndColGroup();
 }
 
+// Inverse of slowColElement:

[Xianzhu, 2016/03/09 18:40:55]

There is no more slowColElement. It's renamed to
slowColElementAtAbsoluteColumn(). Please update.

[atotic1, 2016/03/15 16:50:48]

Done.

+// maps LayoutTableCol to effectiveColumnIndex useful for columnPositions

[Xianzhu, 2016/03/09 18:40:55]

Start a sentence with an uppercase letter.
Add a ';' or '.' at the end.

[atotic1, 2016/03/15 16:50:48]

Done.

+// returns npos if out of range

[Xianzhu, 2016/03/09 18:40:55]

Add a '.' at the end.
We should always find the column of the element (should ASSERT the situation of
not-found), so we should never return error result. 

[atotic1, 2016/03/15 16:50:48]

You are correct. I was finding absolute columns, not effective. Fixe.

+unsigned LayoutTable::colElementToEffectiveColumn(const LayoutTableCol * colElement) const
+{
+    unsigned col = 0;
+    unsigned i;
+    for (i = 0; i < m_columnLayoutObjects.size(); i++) {
+        if (colElement == m_columnLayoutObjects[i]) {
+            break;
+        }
+        col += m_columnLayoutObjects[i]->span();

[Xianzhu, 2016/03/09 18:40:55]

m_columnLayoutObjects[i].span is in number of absolute columns. If you sum up it
here, you'll get the index of absolute column, not effective column.

[atotic1, 2016/03/15 16:50:48]

Done.

+    }
+    if (col < numEffectiveColumns())
+        return col;
+    // else
+        return npos;
+}
+
 void LayoutTable::recalcSections() const
 {
     ASSERT(m_needsSectionRecalc);
 
     m_head = nullptr;
     m_foot = nullptr;
     m_firstBody = nullptr;
     m_hasColElements = false;
     m_hasCellColspanThatDeterminesTableWidth = hasCellColspanThatDeterminesTableWidth();
 
@@ skipping 604 matching lines @@
 
 LayoutUnit LayoutTable::paddingRight() const
 {
     if (collapseBorders())
         return LayoutUnit();
 
     return LayoutBlock::paddingRight();
 }
 
 } // namespace blink