Issue 167693002: Remove use_system_nspr build flag. It's not "officially" supported

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 167693002: Remove use_system_nspr build flag. It's not "officially" supported (Closed)

Created:
6 years, 10 months ago by Ryan Sleevi

Modified:
6 years, 10 months ago

Reviewers:
wtc, Paweł Hajdan Jr.

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove use_system_nspr build flag. It's not "officially" supported BUG=none R=wtc@chromium.org, phajdan.jr@chromium.org TBR=willchan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251527

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -64 lines)			Patch
M	base/base.gyp	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	base/base.gypi	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	base/third_party/nspr/nspr.gyp	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	build/common.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 7 (0 generated)

wtc

Patch set 1 LGTM. I don't remember this build flag. I guess it was intended ...

6 years, 10 months ago (2014-02-15 01:31:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/167693002/1

6 years, 10 months ago (2014-02-15 01:39:53 UTC) #6

Message was sent while issue was closed.

Change committed as 251527