Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1676913004: Banish CFX_WordArray to XFA-land. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : pdfium::CollectionSize<int>() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -102 lines) Patch
M core/include/fxcrt/fx_basic.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 1 9 chunks +24 lines, -21 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 1 13 chunks +49 lines, -64 lines 0 comments Download
M core/src/fpdftext/text_int.h View 3 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 7 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Pls. review.
4 years, 10 months ago (2016-02-08 23:37:31 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1676913004/diff/1/core/src/fpdftext/fpdf_text.cpp File core/src/fpdftext/fpdf_text.cpp (right): https://codereview.chromium.org/1676913004/diff/1/core/src/fpdftext/fpdf_text.cpp#newcode398 core/src/fpdftext/fpdf_text.cpp:398: int count = order.size(); pdfium::CollectionSize<int>() https://codereview.chromium.org/1676913004/diff/1/core/src/fpdftext/fpdf_text_int.cpp File core/src/fpdftext/fpdf_text_int.cpp ...
4 years, 10 months ago (2016-02-09 00:45:22 UTC) #3
Tom Sepez
https://codereview.chromium.org/1676913004/diff/1/core/src/fpdftext/fpdf_text.cpp File core/src/fpdftext/fpdf_text.cpp (right): https://codereview.chromium.org/1676913004/diff/1/core/src/fpdftext/fpdf_text.cpp#newcode398 core/src/fpdftext/fpdf_text.cpp:398: int count = order.size(); On 2016/02/09 00:45:21, Lei Zhang ...
4 years, 10 months ago (2016-02-09 00:57:01 UTC) #4
Tom Sepez
4 years, 10 months ago (2016-02-09 17:56:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
11d93559cea7a0894e05249e7dac2035ad79994e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698