Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 1676883002: [runtime] Optimize and unify rest parameters. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interface-descriptors.cc ('k') | src/interpreter/bytecode-array-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index df0ae93fefab2e41874bd907587f7d91f601ac67..5431412c1536235e5a57a60e78a52f61dbf0e21a 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -24,10 +24,6 @@ namespace interpreter {
class BytecodeLabel;
class Register;
-// TODO(rmcilroy): Unify this with CreateArgumentsParameters::Type in Turbofan
-// when rest parameters implementation has settled down.
rmcilroy 2016/02/08 09:13:18 Thanks for removing this!
-enum class CreateArgumentsType { kMappedArguments, kUnmappedArguments };
-
class BytecodeArrayBuilder final : public ZoneObject, private RegisterMover {
public:
BytecodeArrayBuilder(Isolate* isolate, Zone* zone, int parameter_count,
@@ -152,9 +148,6 @@ class BytecodeArrayBuilder final : public ZoneObject, private RegisterMover {
// Create a new arguments object in the accumulator.
BytecodeArrayBuilder& CreateArguments(CreateArgumentsType type);
- // Create a new rest arguments object starting at |index| in the accumulator.
- BytecodeArrayBuilder& CreateRestArguments(int index);
-
// Literals creation. Constant elements should be in the accumulator.
BytecodeArrayBuilder& CreateRegExpLiteral(Handle<String> pattern,
int literal_index, int flags);
« no previous file with comments | « src/interface-descriptors.cc ('k') | src/interpreter/bytecode-array-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698