Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 1676843002: Make SkPaint movable. (Closed)

Created:
4 years, 10 months ago by bungeman-skia
Modified:
4 years, 10 months ago
Reviewers:
*mtklein, reed2, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkPaint movable. This adds a move constructor and move assignment to SkPaint. This allows elision of atomic increments and decrements on the reference counted fields. Committed: https://skia.googlesource.com/skia/+/ccce0e02576100e1baaab6b18d91acaff624753e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M include/core/SkPaint.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676843002/1
4 years, 10 months ago (2016-02-06 20:37:47 UTC) #4
bungeman-skia
While running dm and looking at SkTArray, saw a number of places this would help.
4 years, 10 months ago (2016-02-06 20:44:58 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-06 21:01:11 UTC) #8
reed2
api lgtm, relying on klein for additional review.
4 years, 10 months ago (2016-02-07 16:43:57 UTC) #11
mtklein
lgtm
4 years, 10 months ago (2016-02-07 19:33:03 UTC) #12
reed1
lgtm
4 years, 10 months ago (2016-02-07 20:07:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676843002/1
4 years, 10 months ago (2016-02-07 22:11:22 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-07 22:37:27 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ccce0e02576100e1baaab6b18d91acaff624753e

Powered by Google App Engine
This is Rietveld 408576698