Add non-inline SkRTreeFactory constructor to fix clang-cl

Add non-inline SkRTreeFactory constructor to fix clang-cl

When Chromium is switched to build with VS 2015 that switches clang-cl
to build in -fmsc-version=1900 mode. This causes some changes in
importing of constructors and vftables which leads to link errors in
blink_platform.dll. Adding a non-inline constructor makes 1900 mode
behave consistently with 1800 mode and avoids the link error.

The root cause needs investigation but this will unblock the VS 2015
switch.

BUG=440500, 498544
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676833002

Committed: https://skia.googlesource.com/skia/+/964eec67760196585954203ba625e440607f7e92

[brucedawson, 2016-02-06 19:37:03]

Description was changed from

==========
Add non-inline SkRTreeFactory constructor to fix clang-cl

When Chromium is switched to build with VS 2015 that switches clang-cl
to build in -fmsc-version=1900 mode. This causes some changes in
importing of constructors and vftables which leads to link errors in
blink_platform.dll. Adding a non-inline constructor makes 1900 mode
behave consistently with 1800 mode and avoids the link error.

The root cause needs investigation but this will unblock the VS 2015
switch.

BUG=440500,498544
==========

to

==========
Add non-inline SkRTreeFactory constructor to fix clang-cl

When Chromium is switched to build with VS 2015 that switches clang-cl
to build in -fmsc-version=1900 mode. This causes some changes in
importing of constructors and vftables which leads to link errors in
blink_platform.dll. Adding a non-inline constructor makes 1900 mode
behave consistently with 1800 mode and avoids the link error.

The root cause needs investigation but this will unblock the VS 2015
switch.

BUG=440500,498544
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[brucedawson, 2016-02-06 19:44:09]

brucedawson@chromium.org changed reviewers:
+ bsalomon@google.com, reed@google.com

[brucedawson, 2016-02-06 19:44:10]

This patch unblocks Chromium's switch to VC++ 2015. While this change isn't
necessary for VC++ 2015 itself, it is necessary for clang-cl when compiling in
VC++ 2015 *mode*.

See https://code.google.com/p/chromium/issues/detail?id=498544#c20 and below for
the details.

thakis@ might have other useful feedback.

[Nico, 2016-02-06 20:07:35]

thakis@chromium.org changed reviewers:
+ mtklein@chromium.org, thakis@chromium.org

[Nico, 2016-02-06 20:07:35]

Cool, good that there's a workaround. Can you add a // TODO(thakis@chromium):
remove once HTTP://llvm.org/26506 is fixed comment please? This lgtm, but I
don't have approval rights on skia land I think. Adding one more skia person in
the hope of reducing LG stamping latency :-)

[bsalomon, 2016-02-06 20:09:15]

lgtm

[brucedawson, 2016-02-06 20:17:34]

On 2016/02/06 20:09:15, bsalomon wrote:
> lgtm

Comment added. Landing and then rolling now.

[brucedawson, 2016-02-06 20:17:52]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-02-06 20:17:53]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1676833002/#ps20001
(title: "Adding requested comment")

[commit-bot: I haz the power, 2016-02-06 20:17:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676833002/20001

[commit-bot: I haz the power, 2016-02-06 20:40:59]

Description was changed from

==========
Add non-inline SkRTreeFactory constructor to fix clang-cl

When Chromium is switched to build with VS 2015 that switches clang-cl
to build in -fmsc-version=1900 mode. This causes some changes in
importing of constructors and vftables which leads to link errors in
blink_platform.dll. Adding a non-inline constructor makes 1900 mode
behave consistently with 1800 mode and avoids the link error.

The root cause needs investigation but this will unblock the VS 2015
switch.

BUG=440500,498544
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add non-inline SkRTreeFactory constructor to fix clang-cl

When Chromium is switched to build with VS 2015 that switches clang-cl
to build in -fmsc-version=1900 mode. This causes some changes in
importing of constructors and vftables which leads to link errors in
blink_platform.dll. Adding a non-inline constructor makes 1900 mode
behave consistently with 1800 mode and avoids the link error.

The root cause needs investigation but this will unblock the VS 2015
switch.

BUG=440500,498544
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/964eec67760196585954203ba625e440607f7e92
==========

[commit-bot: I haz the power, 2016-02-06 20:41:00]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/964eec67760196585954203ba625e440607f7e92

[brucedawson, 2016-02-06 20:45:23]

Chromium tree is closed now and I'll be AFK for a while so if somebody else
wants to roll DEPS when the tree opens, feel free. Otherwise I'll get to it
later this weekend.

[Nico, 2016-02-06 21:44:49]

skia has this fancy bot that auto-rolls skia multiple times per day:
http://codereview.chromium.org/user/skia-deps-roller (…hm, but
https://codereview.chromium.org/1673973002/ suggests it might currently be
disabled due to trouble at skia head?)

[bsalomon, 2016-02-06 22:37:04]

On 2016/02/06 21:44:49, Nico wrote:
> skia has this fancy bot that auto-rolls skia multiple times per day:
> http://codereview.chromium.org/user/skia-deps-roller (…hm, but
> https://codereview.chromium.org/1673973002/ suggests it might currently be
> disabled due to trouble at skia head?)

I'm not sure why it was stopped. This is the only CL not rolled in. I just
restarted it, so hopefully it will roll soon.

[Nico, 2016-02-26 01:25:23]

we can probably undo this now; we updated to a clang that shouldn't need this
workaround any more

[brucedawson, 2016-02-26 20:30:43]

On 2016/02/26 01:25:23, Nico wrote:
> we can probably undo this now; we updated to a clang that shouldn't need this
> workaround any more

I'll do that.

[brucedawson, 2016-02-26 20:31:18]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1739363002/ by brucedawson@chromium.org.

The reason for reverting is: This workaround should no longer be needed..