Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 167683006: Offer single-param version of deepCopyTo -- much easier to migrate to colortypes (Closed)

Created:
6 years, 10 months ago by reed2
Modified:
6 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Offer single-param version of deepCopyTo -- much easier to migrate to colortypes BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M gm/bitmapcopy.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M gm/simpleaaclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkBitmap.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkBitmapHeap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GpuBitmapCopyTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
lgtm
6 years, 10 months ago (2014-02-20 02:15:08 UTC) #1
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-20 02:16:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/167683006/1
6 years, 10 months ago (2014-02-20 02:16:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/167683006/1
6 years, 10 months ago (2014-02-20 02:25:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/167683006/1
6 years, 10 months ago (2014-02-20 03:11:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/167683006/1
6 years, 10 months ago (2014-02-20 04:08:54 UTC) #6
reed1
The CQ bit was unchecked by reed@google.com
6 years, 10 months ago (2014-02-20 17:15:21 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-20 17:15:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/167683006/1
6 years, 10 months ago (2014-02-20 17:15:35 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 19:08:40 UTC) #10
Message was sent while issue was closed. 
Change committed as 13516

Powered by Google App Engine
This is Rietveld 408576698