Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1676793003: Revert of Don't set the origin twice when navigating for javascript: URLs (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, loading-reviews_chromium.org, rwlbuis, sof, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't set the origin twice when navigating for javascript: URLs (patchset #2 id:20001 of https://codereview.chromium.org/1670173002/ ) Reason for revert: Number of MSan failures reported, https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8451 Original issue's description: > Don't set the origin twice when navigating for javascript: URLs > > As javascript: navigations will end up with a document that has the > original document's URL, we shouldn't run the algorithm to determine > origin on the original URL, especially since we'll override the origin > later anyways. > > BUG=583445 > R=japhet@chromium.org,dcheng@chromium.org,mkwst@chromium.org > > Committed: https://crrev.com/75b27bda96f0fe77d40b502642d6669531981a49 > Cr-Commit-Position: refs/heads/master@{#373917} TBR=dcheng@chromium.org,japhet@chromium.org,mkwst@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583445 Committed: https://crrev.com/96c6854b0d976412cc1e7f827c97c3ee1d81cd20 Cr-Commit-Position: refs/heads/master@{#374021}

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
sof
Created Revert of Don't set the origin twice when navigating for javascript: URLs
4 years, 10 months ago (2016-02-06 08:35:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676793003/1
4 years, 10 months ago (2016-02-06 08:36:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-06 08:37:19 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 08:38:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96c6854b0d976412cc1e7f827c97c3ee1d81cd20
Cr-Commit-Position: refs/heads/master@{#374021}

Powered by Google App Engine
This is Rietveld 408576698