Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 167673002: Remove --disable-fullscreen switch (Closed)

Created:
6 years, 10 months ago by scheib
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, James Hawkins, Robert Sesek, rohitrao (ping after 24h), koz (OOO until 15th September)
Visibility:
Public.

Description

Remove --disable-fullscreen switch BUG=343996 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252200

Patch Set 1 #

Patch Set 2 : merge tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/web_preferences.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
scheib
6 years, 10 months ago (2014-02-14 23:40:29 UTC) #1
koz (OOO until 15th September)
lgtm
6 years, 10 months ago (2014-02-17 00:21:22 UTC) #2
scheib
OWNERS, please: kinuko: webkit/common/webpreferences.cc webkit/common/webpreferences.h jochen: content/browser/renderer_host/render_process_host_impl.cc content/browser/renderer_host/render_view_host_impl.cc content/child/runtime_features.cc content/public/common/common_param_traits_macros.h content/public/common/content_switches.cc content/public/common/content_switches.h content/renderer/web_preferences.cc
6 years, 10 months ago (2014-02-18 16:13:53 UTC) #3
kinuko
webkit/common lgtm
6 years, 10 months ago (2014-02-19 03:29:02 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-19 16:01:22 UTC) #5
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 10 months ago (2014-02-19 16:33:59 UTC) #6
scheib
The CQ bit was unchecked by scheib@chromium.org
6 years, 10 months ago (2014-02-19 16:34:01 UTC) #7
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 10 months ago (2014-02-19 16:39:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/167673002/1
6 years, 10 months ago (2014-02-19 16:41:20 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 21:38:30 UTC) #10
commit-bot: I haz the power
Failed to apply patch for content/public/common/content_switches.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-19 21:38:30 UTC) #11
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 10 months ago (2014-02-19 21:52:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/167673002/500001
6 years, 10 months ago (2014-02-19 22:12:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/167673002/500001
6 years, 10 months ago (2014-02-20 00:37:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/167673002/500001
6 years, 10 months ago (2014-02-20 03:18:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/167673002/500001
6 years, 10 months ago (2014-02-20 08:42:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/167673002/500001
6 years, 10 months ago (2014-02-20 12:18:34 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 12:58:51 UTC) #18
Message was sent while issue was closed.
Change committed as 252200

Powered by Google App Engine
This is Rietveld 408576698