ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

ui/views/mus/native_widget_mus.cc

Index: ui/views/mus/native_widget_mus.cc
diff --git a/ui/views/mus/native_widget_mus.cc b/ui/views/mus/native_widget_mus.cc
index de7043f5f3db8e14e71a7868455c9b1e1fa75564..111a32ef8e9da4a71a54a6022b429d92cfb260b5 100644
--- a/ui/views/mus/native_widget_mus.cc
+++ b/ui/views/mus/native_widget_mus.cc
@@ -30,6 +30,7 @@
 #include "ui/views/window/custom_frame_view.h"
 #include "ui/wm/core/base_focus_rules.h"
 #include "ui/wm/core/capture_controller.h"
+#include "ui/wm/core/default_screen_position_client.h"
 #include "ui/wm/core/focus_controller.h"
 
 DECLARE_WINDOW_PROPERTY_TYPE(mus::Window*);
@@ -179,7 +180,6 @@ NativeWidgetMus::NativeWidgetMus(internal::NativeWidgetDelegate* delegate,
                                  mus::Window* window,
                                  mus::mojom::SurfaceType surface_type)
     : window_(window),
-      shell_(shell),
       native_widget_delegate_(delegate),
       surface_type_(surface_type),
       show_state_before_fullscreen_(ui::PLATFORM_WINDOW_STATE_UNKNOWN),
@@ -190,6 +190,21 @@ NativeWidgetMus::NativeWidgetMus(internal::NativeWidgetDelegate* delegate,
   aura::SetMusWindow(content_, window_);
 
   window->SetLocalProperty(kNativeWidgetMusKey, this);
+  // WindowTreeHost creates the compositor using the ContextFactory from

[sky, 2016/02/08 17:42:15]

Seems better to do initialization in InitNativeWidget. I say this as I suspect
InitNativeWidget is going to get more complicated. How come creating the
WindowTreeHost needed to be here?

[sadrul, 2016/02/08 18:33:24]

We need to install the RootWindowSettings for the WTH's root-window between the
creation of the WTHMus, and the call to InitHost(). (because the call to
InitHost() goes back to the associated gfx::Display (to learn about the
device-scale-factor)).

That is why this CL splits the creation of the WTHMus and the call to
WTH::InitHost(). The injected NativeWidgetFactory can then set-up the
RootWindowSettings object at the right time so that subsequent initialization
can completely correctly.

An alternate approach is to keep this code in
NativeWidgetMus::InitNativeWidget(), but introduce a virtual method which gets
called between the WTH creation and the call to InitHost(), so that (1)
NativeWidgetFactory can create a AshNativeWidgetMus, instead of a
NativeWidgetMus from the WMC, and (2) AshNativeWidgetMus overrides the
introduced virtual method to inject the RWH on the root-window. That feels just
as clunky to me, but happy to do that if you think that's cleaner.

+  // aura::Env. Install |context_factory_| there so that |context_factory_| is
+  // picked up.
+  ui::ContextFactory* default_context_factory =
+      aura::Env::GetInstance()->context_factory();
+  // For Chrome, we need the GpuProcessTransportFactory so that renderer and
+  // browser pixels are composited into a single backing
+  // SoftwareOutputDeviceMus.
+  if (!default_context_factory) {
+    context_factory_.reset(
+        new SurfaceContextFactory(shell, window_, surface_type_));
+    aura::Env::GetInstance()->set_context_factory(context_factory_.get());
+  }
+  window_tree_host_.reset(new WindowTreeHostMus(shell, this, window_));
+  aura::Env::GetInstance()->set_context_factory(default_context_factory);
 }
 
 NativeWidgetMus::~NativeWidgetMus() {
@@ -213,6 +228,10 @@ void NativeWidgetMus::NotifyFrameChanged(
   }
 }
 
+aura::Window* NativeWidgetMus::GetRootWindow() {
+  return window_tree_host_->window();
+}
+
 void NativeWidgetMus::OnPlatformWindowClosed() {
   native_widget_delegate_->OnNativeWidgetDestroying();
 
@@ -292,25 +311,8 @@ void NativeWidgetMus::InitNativeWidget(const Widget::InitParams& params) {
   window_->SetCanFocus(params.activatable ==
                        Widget::InitParams::ACTIVATABLE_YES);
 
-  // WindowTreeHost creates the compositor using the ContextFactory from
-  // aura::Env. Install |context_factory_| there so that |context_factory_| is
-  // picked up.
-  ui::ContextFactory* default_context_factory =
-      aura::Env::GetInstance()->context_factory();
-  // For Chrome, we need the GpuProcessTransportFactory so that renderer and
-  // browser pixels are composited into a single backing
-  // SoftwareOutputDeviceMus.
-  if (!default_context_factory) {
-    if (!context_factory_) {
-      context_factory_.reset(new SurfaceContextFactory(shell_, window_,
-                                                       surface_type_));
-    }
-    aura::Env::GetInstance()->set_context_factory(context_factory_.get());
-  }
-  window_tree_host_.reset(new WindowTreeHostMus(shell_, this, window_));
   window_tree_host_->AddObserver(this);
   window_tree_host_->InitHost();
-  aura::Env::GetInstance()->set_context_factory(default_context_factory);
   window_tree_host_->window()->SetProperty(kMusWindow, window_);
 
   focus_client_.reset(new wm::FocusController(new FocusRulesImpl));
@@ -319,6 +321,10 @@ void NativeWidgetMus::InitNativeWidget(const Widget::InitParams& params) {
                                focus_client_.get());
   aura::client::SetActivationClient(window_tree_host_->window(),
                                     focus_client_.get());
+  screen_position_client_.reset(new wm::DefaultScreenPositionClient());
+  aura::client::SetScreenPositionClient(window_tree_host_->window(),
+                                        screen_position_client_.get());
+
   window_tree_client_.reset(
       new NativeWidgetMusWindowTreeClient(window_tree_host_->window()));
   window_tree_host_->window()->AddPreTargetHandler(focus_client_.get());