Test CodecImageGenerator on GPU bots

Test CodecImageGenerator on GPU bots

In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

This is adapted from:
https://codereview.chromium.org/1663453002/

This will cause many untriaged images on Gold.
The GPU converts YUV->RGBA differently than we
do in software.

BUG=skia:4888
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676663002

Committed: https://skia.googlesource.com/skia/+/13a036b7ebfd1faeef168979cd6dbb09d0868619

[msarett, 2016-02-05 21:09:12]

Description was changed from

==========
Test CodecImageGenerator on GPU bots

In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

BUG=skia:
==========

to

==========
Test CodecImageGenerator on GPU bots

In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-02-05 22:53:33]

Description was changed from

==========
Test CodecImageGenerator on GPU bots

In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test CodecImageGenerator on GPU bots

In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

This is adapted from:
https://codereview.chromium.org/1663453002/

BUG=skia:4888
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-02-05 23:18:58]

Patchset #3 (id:40001) has been deleted

[msarett, 2016-02-05 23:19:47]

Description was changed from

==========
Test CodecImageGenerator on GPU bots

In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

This is adapted from:
https://codereview.chromium.org/1663453002/

BUG=skia:4888
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test CodecImageGenerator on GPU bots

In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

This is adapted from:
https://codereview.chromium.org/1663453002/

This will cause many untriaged images on Gold.
The GPU converts YUV->RGBA differently than we
do in software.

BUG=skia:4888
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-02-05 23:19:57]

msarett@google.com changed reviewers:
+ scroggo@google.com

[msarett, 2016-02-08 15:02:30]

Working on a patch to handle this without blacklisting.

[msarett, 2016-02-08 15:14:50]

Patchset #4 (id:80001) has been deleted

[msarett, 2016-02-08 15:56:46]

msarett@google.com changed reviewers:
+ bsalomon@google.com

[msarett, 2016-02-08 15:56:47]

PTAL

I think this is the right fix.

[scroggo, 2016-02-08 16:00:10]

https://codereview.chromium.org/1676663002/diff/100001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1676663002/diff/100001/dm/DMSrcSink.cpp#newco...
dm/DMSrcSink.cpp:860: if (maxDimension < SkTMax(size.width(), size.height())) {
I don't know enough about the GPU code to know if this makes sense. Just based
on the name (maxTextureSize() does not have a comment), I would guess that this
relates to width * height, rather than max(width, height).

[bsalomon, 2016-02-08 16:03:59]

lgtm

[msarett, 2016-02-08 16:20:06]

https://codereview.chromium.org/1676663002/diff/100001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1676663002/diff/100001/dm/DMSrcSink.cpp#newco...
dm/DMSrcSink.cpp:860: if (maxDimension < SkTMax(size.width(), size.height())) {
On 2016/02/08 16:00:09, scroggo wrote:
> I don't know enough about the GPU code to know if this makes sense. Just based
> on the name (maxTextureSize() does not have a comment), I would guess that
this
> relates to width * height, rather than max(width, height).

I had the same confusion before asking Brian :).  Maybe a comment?  On the other
hand, I think the variable name makes it pretty clear.

[scroggo, 2016-02-08 16:23:14]

lgtm

https://codereview.chromium.org/1676663002/diff/100001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1676663002/diff/100001/dm/DMSrcSink.cpp#newco...
dm/DMSrcSink.cpp:860: if (maxDimension < SkTMax(size.width(), size.height())) {
On 2016/02/08 16:20:06, msarett wrote:
> On 2016/02/08 16:00:09, scroggo wrote:
> > I don't know enough about the GPU code to know if this makes sense. Just
based
> > on the name (maxTextureSize() does not have a comment), I would guess that
> this
> > relates to width * height, rather than max(width, height).
> 
> I had the same confusion before asking Brian :).  Maybe a comment?  On the
other
> hand, I think the variable name makes it pretty clear.

Agree that the variable name helps.

[msarett, 2016-02-08 16:24:49]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-02-08 16:24:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676663002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676663002/100001

[commit-bot: I haz the power, 2016-02-08 16:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 16:27:57]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-02-08 16:36:53]

The CQ bit was checked by msarett@google.com

[msarett, 2016-02-08 16:36:55]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1676663002/#ps120001
(title: "Surround size check with SK_SUPPORT_GPU")

[commit-bot: I haz the power, 2016-02-08 16:37:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676663002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676663002/120001

[commit-bot: I haz the power, 2016-02-08 17:10:49]

Description was changed from

==========
Test CodecImageGenerator on GPU bots

In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

This is adapted from:
https://codereview.chromium.org/1663453002/

This will cause many untriaged images on Gold.
The GPU converts YUV->RGBA differently than we
do in software.

BUG=skia:4888
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test CodecImageGenerator on GPU bots

In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

This is adapted from:
https://codereview.chromium.org/1663453002/

This will cause many untriaged images on Gold.
The GPU converts YUV->RGBA differently than we
do in software.

BUG=skia:4888
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/13a036b7ebfd1faeef168979cd6dbb09d0868619
==========

[commit-bot: I haz the power, 2016-02-08 17:10:50]

Committed patchset #5 (id:120001) as
https://skia.googlesource.com/skia/+/13a036b7ebfd1faeef168979cd6dbb09d0868619