Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4643)

Unified Diff: chrome/browser/ui/toolbar/app_menu_model.cc

Issue 1676623002: Update upgrade app menu icons for MD/vectorization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git add Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/upgrade_detector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/app_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/app_menu_model.cc b/chrome/browser/ui/toolbar/app_menu_model.cc
index 395265df592623bba224af692e4cae4de1089bb3..194be531687f40251357ba459a43249776169e3d 100644
--- a/chrome/browser/ui/toolbar/app_menu_model.cc
+++ b/chrome/browser/ui/toolbar/app_menu_model.cc
@@ -361,12 +361,10 @@ base::string16 AppMenuModel::GetLabelForCommandId(int command_id) const {
}
bool AppMenuModel::GetIconForCommandId(int command_id, gfx::Image* icon) const {
- ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
switch (command_id) {
sky 2016/02/08 17:13:17 nit: this is a lot of code just to say: if (comman
Evan Stade 2016/02/08 19:31:12 ha, indeed
case IDC_UPGRADE_DIALOG: {
if (UpgradeDetector::GetInstance()->notify_upgrade()) {
- *icon = rb.GetNativeImageNamed(
- UpgradeDetector::GetInstance()->GetIconResourceID());
+ *icon = UpgradeDetector::GetInstance()->GetIcon();
return true;
}
return false;
« no previous file with comments | « no previous file | chrome/browser/upgrade_detector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698