Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1676623002: Update upgrade app menu icons for MD/vectorization. (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update upgrade app menu icons for MD/vectorization. BUG=559407 TEST=chrome --simulate-critical-update --top-chrome-md=material Committed: https://crrev.com/1e949edc5ffff89e972a94df6af47fa2800f3080 Cr-Commit-Position: refs/heads/master@{#374179}

Patch Set 1 #

Patch Set 2 : git add #

Total comments: 2

Patch Set 3 : reduce verbosity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M chrome/browser/ui/toolbar/app_menu_model.cc View 1 2 1 chunk +4 lines, -12 lines 0 comments Download
M chrome/browser/upgrade_detector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/upgrade_detector.cc View 2 chunks +16 lines, -9 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + ui/gfx/vector_icons/upgrade_menu_item.icon View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Evan Stade
4 years, 10 months ago (2016-02-05 20:30:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676623002/20001
4 years, 10 months ago (2016-02-05 20:34:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-05 22:20:30 UTC) #6
sky
LGTM https://codereview.chromium.org/1676623002/diff/20001/chrome/browser/ui/toolbar/app_menu_model.cc File chrome/browser/ui/toolbar/app_menu_model.cc (right): https://codereview.chromium.org/1676623002/diff/20001/chrome/browser/ui/toolbar/app_menu_model.cc#newcode364 chrome/browser/ui/toolbar/app_menu_model.cc:364: switch (command_id) { nit: this is a lot ...
4 years, 10 months ago (2016-02-08 17:13:17 UTC) #7
Evan Stade
https://codereview.chromium.org/1676623002/diff/20001/chrome/browser/ui/toolbar/app_menu_model.cc File chrome/browser/ui/toolbar/app_menu_model.cc (right): https://codereview.chromium.org/1676623002/diff/20001/chrome/browser/ui/toolbar/app_menu_model.cc#newcode364 chrome/browser/ui/toolbar/app_menu_model.cc:364: switch (command_id) { On 2016/02/08 17:13:17, sky wrote: > ...
4 years, 10 months ago (2016-02-08 19:31:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676623002/40001
4 years, 10 months ago (2016-02-08 19:35:49 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-08 21:19:53 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 21:20:58 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1e949edc5ffff89e972a94df6af47fa2800f3080
Cr-Commit-Position: refs/heads/master@{#374179}

Powered by Google App Engine
This is Rietveld 408576698